On Wed, 10 Aug 2022, Andrzej Hajda <andrzej.hajda@xxxxxxxxx> wrote: > On 05.08.2022 17:59, Piorkowski, Piotr wrote: >> +/* PCI BARs */ >> +#define GTTMMADR_BAR 0 >> +#define GEN2_GTTMMADR_BAR 1 >> +#define GFXMEM_BAR 2 >> +#define GTT_APERTURE_BAR GFXMEM_BAR >> +#define GEN12_LMEM_BAR GFXMEM_BAR > > In INTEL_GVT_PCI_BAR_GTTMMIO we have BAR in prefix, here in suffix. > I am not sure which onel is better, just pointing out slight incosistency. Thought about it too, but decided this one's trivial to change if needed. The main change is switching to macros. > Anyway: > Reviewed-by: Andrzej Hajda <andrzej.hajda@xxxxxxxxx> Thanks, though I already pushed this. :) BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center
