On Wed, 10 Aug 2022, "Murthy, Arun R" <arun.r.murthy@xxxxxxxxx> wrote: >> -----Original Message----- >> From: Intel-gfx <intel-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Jani >> Nikula >> Sent: Thursday, August 4, 2022 3:29 PM >> To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx >> Cc: Nikula, Jani <jani.nikula@xxxxxxxxx> >> Subject: [PATCH 2/2] drm/i915/hdcp: replace BIT() with REG_BIT() >> in register definitions >> >> Registers contents are supposed to be defined using REG_BIT() to ensure >> they're u32 and the shift is within bounds. >> >> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx> >> --- > > Reviewed-by: Arun R Murthy <arun.r.murthy@xxxxxxxxx> Thanks for the review, pushed both. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center