Hi, On 7/13/22 19:21, Limonciello, Mario wrote: > [Public] > > > >> -----Original Message----- >> From: Werner Sembach <wse@xxxxxxxxxxxxxxxxxxx> >> Sent: Wednesday, July 13, 2022 12:08 >> To: Hans de Goede <hdegoede@xxxxxxxxxx>; Ben Skeggs >> <bskeggs@xxxxxxxxxx>; Karol Herbst <kherbst@xxxxxxxxxx>; Lyude >> <lyude@xxxxxxxxxx>; Daniel Dadap <ddadap@xxxxxxxxxx>; Maarten >> Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>; Maxime Ripard >> <mripard@xxxxxxxxxx>; Thomas Zimmermann <tzimmermann@xxxxxxx>; >> Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>; Joonas Lahtinen >> <joonas.lahtinen@xxxxxxxxxxxxxxx>; Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>; >> Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxxxxxxxx>; Deucher, Alexander >> <Alexander.Deucher@xxxxxxx>; Koenig, Christian >> <Christian.Koenig@xxxxxxx>; Pan@xxxxxxxxxxxxxxx; Pan, Xinhui >> <Xinhui.Pan@xxxxxxx>; Rafael J . Wysocki <rafael@xxxxxxxxxx>; Mika >> Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>; Lukas Wunner >> <lukas@xxxxxxxxx>; Mark Gross <markgross@xxxxxxxxxx>; Andy >> Shevchenko <andy@xxxxxxxxxx> >> Cc: nouveau@xxxxxxxxxxxxxxxxxxxxx; Daniel Vetter <daniel@xxxxxxxx>; David >> Airlie <airlied@xxxxxxxx>; intel-gfx <intel-gfx@xxxxxxxxxxxxxxxxxxxxx>; dri- >> devel@xxxxxxxxxxxxxxxxxxxxx; amd-gfx@xxxxxxxxxxxxxxxxxxxxx; Len Brown >> <lenb@xxxxxxxxxx>; linux-acpi@xxxxxxxxxxxxxxx; platform-driver- >> x86@xxxxxxxxxxxxxxx >> Subject: Re: [PATCH v2 27/29] ACPI: video: Drop Clevo/TUXEDO NL5xRU and >> NL5xNU acpi_backlight=native quirks >> >> Hi, >> >> On 7/12/22 21:39, Hans de Goede wrote: >>> acpi_backlight=native is the default for these, but as the comment >>> explains the quirk was still necessary because even briefly registering >>> the acpi_video0 backlight; and then unregistering it once the native >>> driver showed up, was leading to issues. >>> >>> After the "ACPI: video: Make backlight class device registration >>> a separate step" patch from earlier in this patch-series, we no >>> longer briefly register the acpi_video0 backlight on systems where >>> the native driver should be used. >>> >>> So this is no longer an issue an the quirks are no longer needed. >>> >>> Cc: Werner Sembach <wse@xxxxxxxxxxxxxxxxxxx> >>> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> >> >> Tested and can confirm: The quirks are no longer needed with this Patchset. >> >> Tested-by: Werner Sembach <wse@xxxxxxxxxxxxxxxxxxx> > > Probably should include this link tag in this commit too then as it fixes > the Tong Fang systems too. > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=215683 Good point, I've added this to the version in my personal tree. Regards, Hans > >> >> Kind Regards, >> >> Werner Sembach >> >>> --- >>> drivers/acpi/video_detect.c | 75 ------------------------------------- >>> 1 file changed, 75 deletions(-) >>> >>> diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c >>> index 2a4d376a703e..4b9395d1bda7 100644 >>> --- a/drivers/acpi/video_detect.c >>> +++ b/drivers/acpi/video_detect.c >>> @@ -599,81 +599,6 @@ static const struct dmi_system_id >> video_detect_dmi_table[] = { >>> DMI_MATCH(DMI_BOARD_NAME, "N250P"), >>> }, >>> }, >>> - /* >>> - * Clevo NL5xRU and NL5xNU/TUXEDO Aura 15 Gen1 and Gen2 have >> both a >>> - * working native and video interface. However the default detection >>> - * mechanism first registers the video interface before unregistering >>> - * it again and switching to the native interface during boot. This >>> - * results in a dangling SBIOS request for backlight change for some >>> - * reason, causing the backlight to switch to ~2% once per boot on >> the >>> - * first power cord connect or disconnect event. Setting the native >>> - * interface explicitly circumvents this buggy behaviour, by avoiding >>> - * the unregistering process. >>> - */ >>> - { >>> - .callback = video_detect_force_native, >>> - .ident = "Clevo NL5xRU", >>> - .matches = { >>> - DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"), >>> - DMI_MATCH(DMI_BOARD_NAME, "NL5xRU"), >>> - }, >>> - }, >>> - { >>> - .callback = video_detect_force_native, >>> - .ident = "Clevo NL5xRU", >>> - .matches = { >>> - DMI_MATCH(DMI_SYS_VENDOR, >> "SchenkerTechnologiesGmbH"), >>> - DMI_MATCH(DMI_BOARD_NAME, "NL5xRU"), >>> - }, >>> - }, >>> - { >>> - .callback = video_detect_force_native, >>> - .ident = "Clevo NL5xRU", >>> - .matches = { >>> - DMI_MATCH(DMI_SYS_VENDOR, "Notebook"), >>> - DMI_MATCH(DMI_BOARD_NAME, "NL5xRU"), >>> - }, >>> - }, >>> - { >>> - .callback = video_detect_force_native, >>> - .ident = "Clevo NL5xRU", >>> - .matches = { >>> - DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"), >>> - DMI_MATCH(DMI_BOARD_NAME, "AURA1501"), >>> - }, >>> - }, >>> - { >>> - .callback = video_detect_force_native, >>> - .ident = "Clevo NL5xRU", >>> - .matches = { >>> - DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"), >>> - DMI_MATCH(DMI_BOARD_NAME, "EDUBOOK1502"), >>> - }, >>> - }, >>> - { >>> - .callback = video_detect_force_native, >>> - .ident = "Clevo NL5xNU", >>> - .matches = { >>> - DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"), >>> - DMI_MATCH(DMI_BOARD_NAME, "NL5xNU"), >>> - }, >>> - }, >>> - { >>> - .callback = video_detect_force_native, >>> - .ident = "Clevo NL5xNU", >>> - .matches = { >>> - DMI_MATCH(DMI_SYS_VENDOR, >> "SchenkerTechnologiesGmbH"), >>> - DMI_MATCH(DMI_BOARD_NAME, "NL5xNU"), >>> - }, >>> - }, >>> - { >>> - .callback = video_detect_force_native, >>> - .ident = "Clevo NL5xNU", >>> - .matches = { >>> - DMI_MATCH(DMI_SYS_VENDOR, "Notebook"), >>> - DMI_MATCH(DMI_BOARD_NAME, "NL5xNU"), >>> - }, >>> - }, >>> >>> /* >>> * Desktops which falsely report a backlight and which our heuristics
