On Wed, Jul 13, 2022 at 09:11:57AM +0100, Mauro Carvalho Chehab wrote: > Two documented functions don't match the kernel-doc comments, > as reported by kernel-doc: > > drivers/gpu/drm/i915/intel_wakeref.h:117: warning: expecting prototype for intel_wakeref_get_if_in_use(). Prototype was for intel_wakeref_get_if_active() instead > drivers/gpu/drm/i915/intel_wakeref.h:149: warning: expecting prototype for intel_wakeref_put_flags(). Prototype was for __intel_wakeref_put() instead > > Fix them. > > Additionally, improve title for intel_wakeref_get_if_active(). > > Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> > --- > > To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. > See [PATCH v2 00/39] at: https://lore.kernel.org/all/cover.1657699522.git.mchehab@xxxxxxxxxx/ > > drivers/gpu/drm/i915/intel_wakeref.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_wakeref.h b/drivers/gpu/drm/i915/intel_wakeref.h > index 4f4c2e15e736..63e539c9b1f3 100644 > --- a/drivers/gpu/drm/i915/intel_wakeref.h > +++ b/drivers/gpu/drm/i915/intel_wakeref.h > @@ -104,7 +104,7 @@ __intel_wakeref_get(struct intel_wakeref *wf) > } > > /** > - * intel_wakeref_get_if_in_use: Acquire the wakeref > + * intel_wakeref_get_if_active: Acquire the wakeref if active > * @wf: the wakeref > * > * Acquire a hold on the wakeref, but only if the wakeref is already > @@ -130,7 +130,7 @@ intel_wakeref_might_get(struct intel_wakeref *wf) > } > > /** > - * intel_wakeref_put_flags: Release the wakeref > + * __intel_wakeref_put: Release the wakeref > * @wf: the wakeref > * @flags: control flags > * > -- > 2.36.1 >
