On Wed, Jul 13, 2022 at 09:11:53AM +0100, Mauro Carvalho Chehab wrote: > There are a couple of issues at i915 display kernel-doc markups: > > drivers/gpu/drm/i915/display/intel_display_debugfs.c:2238: warning: Function parameter or member 'intel_connector' not described in 'intel_connector_debugfs_add' > drivers/gpu/drm/i915/display/intel_display_debugfs.c:2238: warning: Excess function parameter 'connector' description in 'intel_connector_debugfs_add' > drivers/gpu/drm/i915/display/intel_display_power.c:700: warning: expecting prototype for intel_display_power_put_async(). Prototype was for __intel_display_power_put_async() instead > drivers/gpu/drm/i915/display/intel_tc.c:807: warning: Function parameter or member 'work' not described in 'intel_tc_port_disconnect_phy_work' > drivers/gpu/drm/i915/display/intel_tc.c:807: warning: Excess function parameter 'dig_port' description in 'intel_tc_port_disconnect_phy_work' > > Those are due to wrong parameter of function name. Address them. > > Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> > --- > > To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. > See [PATCH v2 00/39] at: https://lore.kernel.org/all/cover.1657699522.git.mchehab@xxxxxxxxxx/ > > drivers/gpu/drm/i915/display/intel_display_debugfs.c | 2 +- > drivers/gpu/drm/i915/display/intel_display_power.c | 2 +- > drivers/gpu/drm/i915/display/intel_tc.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c > index 6c3954479047..1e35eb01742b 100644 > --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c > +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c > @@ -2229,7 +2229,7 @@ DEFINE_SHOW_ATTRIBUTE(i915_current_bpc); > > /** > * intel_connector_debugfs_add - add i915 specific connector debugfs files > - * @connector: pointer to a registered drm_connector > + * @intel_connector: pointer to a registered drm_connector > * > * Cleanup will be done by drm_connector_unregister() through a call to > * drm_debugfs_connector_remove(). > diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c > index 589af257edeb..fd6b71160a06 100644 > --- a/drivers/gpu/drm/i915/display/intel_display_power.c > +++ b/drivers/gpu/drm/i915/display/intel_display_power.c > @@ -685,7 +685,7 @@ intel_display_power_put_async_work(struct work_struct *work) > } > > /** > - * intel_display_power_put_async - release a power domain reference asynchronously > + * __intel_display_power_put_async - release a power domain reference asynchronously oh, we are really using __ prefix for non-static functions?! o.O anyway, with that ditto "()" consistency, Reviewed-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> > * @i915: i915 device instance > * @domain: power domain to reference > * @wakeref: wakeref acquired for the reference that is being released > diff --git a/drivers/gpu/drm/i915/display/intel_tc.c b/drivers/gpu/drm/i915/display/intel_tc.c > index 6773840f6cc7..7ce0cbe0de05 100644 > --- a/drivers/gpu/drm/i915/display/intel_tc.c > +++ b/drivers/gpu/drm/i915/display/intel_tc.c > @@ -797,7 +797,7 @@ void intel_tc_port_lock(struct intel_digital_port *dig_port) > > /** > * intel_tc_port_disconnect_phy_work: disconnect TypeC PHY from display port > - * @dig_port: digital port > + * @work: workqueue struct > * > * Disconnect the given digital port from its TypeC PHY (handing back the > * control of the PHY to the TypeC subsystem). This will happen in a delayed > -- > 2.36.1 >
