Re: [PATCH i-g-t] Revert "lib/i915: request CPU_ACCESS for fb objects"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@xxxxxxxxx>

On 7.7.2022 15.23, Matthew Auld wrote:
This reverts commit 3cf110f8dcd1f4f02cf84339664b413abdaebf7d.

This is too big of a hammer it seems, since we can't really support
flat-CCS with lmem + smem objects, and here adding the flag means we
also attach the smem placement, which seems to break kms_ccs.

Signed-off-by: Matthew Auld <matthew.auld@xxxxxxxxx>
Cc: Juha-Pekka Heikkila <juhapekka.heikkila@xxxxxxxxx>
Cc: Nirmoy Das <nirmoy.das@xxxxxxxxx>
---
  lib/ioctl_wrappers.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c
index 7713e78b..09eb3ce7 100644
--- a/lib/ioctl_wrappers.c
+++ b/lib/ioctl_wrappers.c
@@ -635,8 +635,7 @@ uint32_t gem_buffer_create_fb_obj(int fd, uint64_t size)
  	uint32_t handle;
if (gem_has_lmem(fd))
-		handle = gem_create_with_cpu_access_in_memory_regions(fd, size,
-								      REGION_LMEM(0));
+		handle = gem_create_in_memory_regions(fd, size, REGION_LMEM(0));
  	else
  		handle = gem_create(fd, size);




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux