== Series Details == Series: drm/i915/gt: Add general DSS steering iterator to intel_gt_mcr (rev2) URL : https://patchwork.freedesktop.org/series/105883/ State : warning == Summary == Error: dim checkpatch failed d4f96890b01e drm/i915/gt: Add general DSS steering iterator to intel_gt_mcr -:135: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #135: FILE: drivers/gpu/drm/i915/gt/intel_gt_mcr.c:509: +void intel_gt_mcr_get_ss_steering(struct intel_gt *gt, unsigned int dss, + unsigned int *group, unsigned int *instance) -:166: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'gt_' - possible side-effects? #166: FILE: drivers/gpu/drm/i915/gt/intel_gt_mcr.h:43: +#define _HAS_SS(ss_, gt_, group_, instance_) ( \ + GRAPHICS_VER_FULL(gt_->i915) >= IP_VER(12, 50) ? \ + intel_sseu_has_subslice(&(gt_)->info.sseu, 0, ss_) : \ + intel_sseu_has_subslice(&(gt_)->info.sseu, group_, instance_)) -:166: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'gt_' may be better as '(gt_)' to avoid precedence issues #166: FILE: drivers/gpu/drm/i915/gt/intel_gt_mcr.h:43: +#define _HAS_SS(ss_, gt_, group_, instance_) ( \ + GRAPHICS_VER_FULL(gt_->i915) >= IP_VER(12, 50) ? \ + intel_sseu_has_subslice(&(gt_)->info.sseu, 0, ss_) : \ + intel_sseu_has_subslice(&(gt_)->info.sseu, group_, instance_)) -:175: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ss_' - possible side-effects? #175: FILE: drivers/gpu/drm/i915/gt/intel_gt_mcr.h:52: +#define for_each_ss_steering(ss_, gt_, group_, instance_) \ + for (ss_ = 0, intel_gt_mcr_get_ss_steering(gt_, 0, &group_, &instance_); \ + ss_ < I915_MAX_SS_FUSE_BITS; \ + ss_++, intel_gt_mcr_get_ss_steering(gt_, ss_, &group_, &instance_)) \ + for_each_if(_HAS_SS(ss_, gt_, group_, instance_)) -:175: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'gt_' - possible side-effects? #175: FILE: drivers/gpu/drm/i915/gt/intel_gt_mcr.h:52: +#define for_each_ss_steering(ss_, gt_, group_, instance_) \ + for (ss_ = 0, intel_gt_mcr_get_ss_steering(gt_, 0, &group_, &instance_); \ + ss_ < I915_MAX_SS_FUSE_BITS; \ + ss_++, intel_gt_mcr_get_ss_steering(gt_, ss_, &group_, &instance_)) \ + for_each_if(_HAS_SS(ss_, gt_, group_, instance_)) -:175: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'group_' - possible side-effects? #175: FILE: drivers/gpu/drm/i915/gt/intel_gt_mcr.h:52: +#define for_each_ss_steering(ss_, gt_, group_, instance_) \ + for (ss_ = 0, intel_gt_mcr_get_ss_steering(gt_, 0, &group_, &instance_); \ + ss_ < I915_MAX_SS_FUSE_BITS; \ + ss_++, intel_gt_mcr_get_ss_steering(gt_, ss_, &group_, &instance_)) \ + for_each_if(_HAS_SS(ss_, gt_, group_, instance_)) -:175: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'group_' may be better as '(group_)' to avoid precedence issues #175: FILE: drivers/gpu/drm/i915/gt/intel_gt_mcr.h:52: +#define for_each_ss_steering(ss_, gt_, group_, instance_) \ + for (ss_ = 0, intel_gt_mcr_get_ss_steering(gt_, 0, &group_, &instance_); \ + ss_ < I915_MAX_SS_FUSE_BITS; \ + ss_++, intel_gt_mcr_get_ss_steering(gt_, ss_, &group_, &instance_)) \ + for_each_if(_HAS_SS(ss_, gt_, group_, instance_)) -:175: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'instance_' - possible side-effects? #175: FILE: drivers/gpu/drm/i915/gt/intel_gt_mcr.h:52: +#define for_each_ss_steering(ss_, gt_, group_, instance_) \ + for (ss_ = 0, intel_gt_mcr_get_ss_steering(gt_, 0, &group_, &instance_); \ + ss_ < I915_MAX_SS_FUSE_BITS; \ + ss_++, intel_gt_mcr_get_ss_steering(gt_, ss_, &group_, &instance_)) \ + for_each_if(_HAS_SS(ss_, gt_, group_, instance_)) -:175: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'instance_' may be better as '(instance_)' to avoid precedence issues #175: FILE: drivers/gpu/drm/i915/gt/intel_gt_mcr.h:52: +#define for_each_ss_steering(ss_, gt_, group_, instance_) \ + for (ss_ = 0, intel_gt_mcr_get_ss_steering(gt_, 0, &group_, &instance_); \ + ss_ < I915_MAX_SS_FUSE_BITS; \ + ss_++, intel_gt_mcr_get_ss_steering(gt_, ss_, &group_, &instance_)) \ + for_each_if(_HAS_SS(ss_, gt_, group_, instance_)) total: 0 errors, 0 warnings, 9 checks, 237 lines checked
