On Mon, 27 Jun 2022 16:03:46 -0700, Vinay Belgaumkar wrote: > > /* Actual frequency should rise above min */ > - if (max_act_freq == slpc_min_freq) { > + if (max_act_freq <= slpc_min_freq) { > pr_err("Actual freq did not rise above min\n"); > + pr_err("Perf Limit Reasons: 0x%x\n", > + intel_uncore_read(gt->uncore, GT0_PERF_LIMIT_REASONS)); > err = -EINVAL; > } Maybe to be clear, we should combine these two pr_err's into a single pr_err. In any case this patch is: Reviewed-by: Ashutosh Dixit <ashutosh.dixit@xxxxxxxxx>