Re: [PATCH] drm/i915/guc/slpc: Add a new SLPC selftest

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 27 Jun 2022 16:03:46 -0700, Vinay Belgaumkar wrote:
>
>		/* Actual frequency should rise above min */
> -		if (max_act_freq == slpc_min_freq) {
> +		if (max_act_freq <= slpc_min_freq) {
>			pr_err("Actual freq did not rise above min\n");
> +			pr_err("Perf Limit Reasons: 0x%x\n",
> +			       intel_uncore_read(gt->uncore, GT0_PERF_LIMIT_REASONS));
>			err = -EINVAL;
>		}

Maybe to be clear, we should combine these two pr_err's into a single
pr_err.

In any case this patch is:

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@xxxxxxxxx>



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux