== Series Details == Series: drm/i915/guc/slpc: Add a new SLPC selftest (rev3) URL : https://patchwork.freedesktop.org/series/105005/ State : warning == Summary == Error: dim checkpatch failed 4982a0bd3fa6 drm/i915/guc/slpc: Add a new SLPC selftest -:13: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #13: code duplication. Rename the "clamp" tests to vary_max_freq and vary_min_freq. -:18: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 8ee2c227822e ("drm/i915/guc/slpc: Add SLPC selftest")' #18: Fixes 8ee2c227822e ("drm/i915/guc/slpc: Add SLPC selftest") -:81: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #81: FILE: drivers/gpu/drm/i915/gt/selftest_slpc.c:65: + pr_err("SWReq is %d, should be at most %d\n", req_freq, + max_freq + FREQUENCY_REQ_UNIT); -:161: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #161: FILE: drivers/gpu/drm/i915/gt/selftest_slpc.c:101: + pr_err("SWReq is %d, should be at least %d\n", req_freq, + min_freq - FREQUENCY_REQ_UNIT); -:226: CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #226: FILE: drivers/gpu/drm/i915/gt/selftest_slpc.c:138: + } -:347: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'engine->class == VIDEO_DECODE_CLASS' #347: FILE: drivers/gpu/drm/i915/gt/selftest_slpc.c:219: + if ((engine->class == VIDEO_DECODE_CLASS) || + (engine->class == VIDEO_ENHANCEMENT_CLASS)) { -:347: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'engine->class == VIDEO_ENHANCEMENT_CLASS' #347: FILE: drivers/gpu/drm/i915/gt/selftest_slpc.c:219: + if ((engine->class == VIDEO_DECODE_CLASS) || + (engine->class == VIDEO_ENHANCEMENT_CLASS)) { -:378: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #378: FILE: drivers/gpu/drm/i915/gt/selftest_slpc.c:238: + pr_err("Perf Limit Reasons: 0x%x\n", + intel_uncore_read(gt->uncore, GT0_PERF_LIMIT_REASONS)); -:407: CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #407: FILE: drivers/gpu/drm/i915/gt/selftest_slpc.c:262: + +} total: 1 errors, 1 warnings, 7 checks, 415 lines checked
