Re: [PATCH v2 03/12] drm/i915/uapi: expose the avail tracking

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Matthew,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on drm-tip/drm-tip]
[also build test WARNING on linus/master v5.19-rc3 next-20220621]
[cannot apply to drm-intel/for-linux-next drm/drm-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Matthew-Auld/small-BAR-uapi-bits/20220621-184858
base:   git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: i386-randconfig-a004 (https://download.01.org/0day-ci/archive/20220622/202206220325.JAXbxJ16-lkp@xxxxxxxxx/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project af6d2a0b6825e71965f3e2701a63c239fa0ad70f)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/c421b7689a4552aa8e3acc2fe558d097c464870e
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Matthew-Auld/small-BAR-uapi-bits/20220621-184858
        git checkout c421b7689a4552aa8e3acc2fe558d097c464870e
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/gpu/drm/i915/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/i915/i915_ttm_buddy_manager.c:374: warning: expecting prototype for i915_ttm_buddy_man_visible_size(). Prototype was for i915_ttm_buddy_man_avail() instead


vim +374 drivers/gpu/drm/i915/i915_ttm_buddy_manager.c

   362	
   363	/**
   364	 * i915_ttm_buddy_man_visible_size - Query the avail tracking for the manager.
   365	 *
   366	 * @man: The buddy allocator ttm manager
   367	 * @avail: The total available memory in pages for the entire manager.
   368	 * @visible_avail: The total available memory in pages for the CPU visible
   369	 * portion. Note that this will always give the same value as @avail on
   370	 * configurations that don't have a small BAR.
   371	 */
   372	void i915_ttm_buddy_man_avail(struct ttm_resource_manager *man,
   373				     u64 *avail, u64 *visible_avail)
 > 374	{
   375		struct i915_ttm_buddy_manager *bman = to_buddy_manager(man);
   376	
   377		mutex_lock(&bman->lock);
   378		*avail = bman->mm.avail >> PAGE_SHIFT;
   379		*visible_avail = bman->visible_avail;
   380		mutex_unlock(&bman->lock);
   381	}
   382	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux