> > @@ -5224,7 +5225,8 @@ static bool intel_edp_init_connector(struct intel_dp > *intel_dp, > > } > > intel_connector->edid = edid; > > > > - intel_bios_init_panel(dev_priv, &intel_connector->panel, > > + devdata = dev_priv->vbt.ports[intel_connector->encoder->port]; > > Sorry, i915->vbt.ports[] is supposed to be private to intel_bios.c. I tried to > explain that we already look up devdata for some of the encoders. See > intel_ddi_init() which is relevant for new platforms. > > We've got > > devdata = intel_bios_encoder_data_lookup(dev_priv, port); > > and > > encoder->devdata = devdata; > > So you just need to get at the encoder here (via intel_dp), and pass > encoder->devdata. > > With that fixed, this LGTM. Thanks Jani for review, updated the same in v4 Regards, Animesh
