On Thu, Jun 16, 2022 at 12:48:10PM +0300, Jani Nikula wrote: > v2 of [1]. Address review comments, drop crtc state compare move, add hw > state readout&sanitization split, and sprinkle some struct > drm_i915_private *i915 cleanups on top. > > BR, > Jani. > > [1] https://patchwork.freedesktop.org/series/105156/ > > > Jani Nikula (11): > drm/i915/wm: move wm state verification to intel_pm.c > drm/i915/dpll: move shared dpll state verification to intel_dpll_mgr.c > drm/i915/mpllb: use I915_STATE_WARN() for state mismatch warnings > drm/i915/mpllb: move mpllb state check to intel_snps_phy.c > drm/i915/display: split out modeset verification code > drm/i915/display: split out crtc state dump to a separate file > drm/i915/display: change who adds [] around crtc state dump context > string > drm/i915/display: rename dev_priv -> i915 in crtc state dump > drm/i915/display: split out hw state readout and sanitize > drm/i915/display: some struct drm_i915_private *i915 conversions > drm/i915/display: convert modeset setup to struct drm_i915_private > *i915 Series is Reviewed-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > drivers/gpu/drm/i915/Makefile | 3 + > .../drm/i915/display/intel_crtc_state_dump.c | 314 +++ > .../drm/i915/display/intel_crtc_state_dump.h | 16 + > drivers/gpu/drm/i915/display/intel_display.c | 1680 +---------------- > drivers/gpu/drm/i915/display/intel_display.h | 18 + > drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 88 + > drivers/gpu/drm/i915/display/intel_dpll_mgr.h | 5 + > .../drm/i915/display/intel_modeset_setup.c | 724 +++++++ > .../drm/i915/display/intel_modeset_setup.h | 15 + > .../drm/i915/display/intel_modeset_verify.c | 246 +++ > .../drm/i915/display/intel_modeset_verify.h | 21 + > drivers/gpu/drm/i915/display/intel_snps_phy.c | 43 + > drivers/gpu/drm/i915/display/intel_snps_phy.h | 5 +- > drivers/gpu/drm/i915/intel_pm.c | 138 +- > drivers/gpu/drm/i915/intel_pm.h | 14 +- > 15 files changed, 1724 insertions(+), 1606 deletions(-) > create mode 100644 drivers/gpu/drm/i915/display/intel_crtc_state_dump.c > create mode 100644 drivers/gpu/drm/i915/display/intel_crtc_state_dump.h > create mode 100644 drivers/gpu/drm/i915/display/intel_modeset_setup.c > create mode 100644 drivers/gpu/drm/i915/display/intel_modeset_setup.h > create mode 100644 drivers/gpu/drm/i915/display/intel_modeset_verify.c > create mode 100644 drivers/gpu/drm/i915/display/intel_modeset_verify.h > > -- > 2.30.2 -- Ville Syrjälä Intel