== Series Details == Series: drm/i915/guc/slpc: Add a new SLPC selftest (rev2) URL : https://patchwork.freedesktop.org/series/105005/ State : warning == Summary == Error: dim checkpatch failed d128b50efeb4 drm/i915/guc/slpc: Add a new SLPC selftest -:13: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #13: code duplication. Rename the "clamp" tests to vary_max_freq and vary_min_freq. -:17: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 8ee2c227822e ("drm/i915/guc/slpc: Add SLPC selftest")' #17: Fixes 8ee2c227822e ("drm/i915/guc/slpc: Add SLPC selftest") -:42: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #42: FILE: drivers/gpu/drm/i915/gt/selftest_slpc.c:45: +static int vary_max_freq(struct intel_guc_slpc *slpc, struct intel_rps *rps, + u32 *max_act_freq) -:122: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #122: FILE: drivers/gpu/drm/i915/gt/selftest_slpc.c:69: + pr_err("SWReq is %d, should be at most %d\n", req_freq, + max_freq + FREQUENCY_REQ_UNIT); -:161: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #161: FILE: drivers/gpu/drm/i915/gt/selftest_slpc.c:85: +static int vary_min_freq(struct intel_guc_slpc *slpc, struct intel_rps *rps, + u32 *max_act_freq) -:196: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #196: FILE: drivers/gpu/drm/i915/gt/selftest_slpc.c:109: + pr_err("SWReq is %d, should be at least %d\n", req_freq, + min_freq - FREQUENCY_REQ_UNIT); -:348: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'engine->class == VIDEO_DECODE_CLASS' #348: FILE: drivers/gpu/drm/i915/gt/selftest_slpc.c:224: + if ((engine->class == VIDEO_DECODE_CLASS) || + (engine->class == VIDEO_ENHANCEMENT_CLASS)) { -:348: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'engine->class == VIDEO_ENHANCEMENT_CLASS' #348: FILE: drivers/gpu/drm/i915/gt/selftest_slpc.c:224: + if ((engine->class == VIDEO_DECODE_CLASS) || + (engine->class == VIDEO_ENHANCEMENT_CLASS)) { -:401: CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #401: FILE: drivers/gpu/drm/i915/gt/selftest_slpc.c:265: + +} total: 1 errors, 1 warnings, 7 checks, 411 lines checked
