Re: [PATCH] drm/i915/guc: Use drm_err instead of pr_err

[kernel test robot <lkp@xxxxxxxxx>]

Hi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on v5.19-rc1]
[also build test ERROR on next-20220610]
[cannot apply to drm-intel/for-linux-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/John-C-Harrison-Intel-com/drm-i915-guc-Use-drm_err-instead-of-pr_err/20220608-055315
base:    f2906aa863381afb0015a9eb7fefad885d4e5a56
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20220611/202206111316.zDpQcjgJ-lkp@xxxxxxxxx/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/66426324c5bb1a53dd401b7d781c3c9c58f163d5
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review John-C-Harrison-Intel-com/drm-i915-guc-Use-drm_err-instead-of-pr_err/20220608-055315
        git checkout 66426324c5bb1a53dd401b7d781c3c9c58f163d5
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   In file included from drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:4956:
   drivers/gpu/drm/i915/gt/uc/selftest_guc_multi_lrc.c: In function '__intel_guc_multi_lrc_basic':
>> drivers/gpu/drm/i915/gt/uc/selftest_guc_multi_lrc.c:121:17: error: implicit declaration of function 'drm_debug'; did you mean 'pr_debug'? [-Werror=implicit-function-declaration]
     121 |                 drm_debug(&gt->i915->drm, "Not enough engines in class: %d", class);
         |                 ^~~~~~~~~
         |                 pr_debug
   cc1: all warnings being treated as errors


vim +121 drivers/gpu/drm/i915/gt/uc/selftest_guc_multi_lrc.c

   109	
   110	static int __intel_guc_multi_lrc_basic(struct intel_gt *gt, unsigned int class)
   111	{
   112		struct intel_context *parent;
   113		struct i915_request *rq;
   114		int ret;
   115	
   116		parent = multi_lrc_create_parent(gt, class, 0);
   117		if (IS_ERR(parent)) {
   118			drm_err(&gt->i915->drm, "Failed creating contexts: %ld", PTR_ERR(parent));
   119			return PTR_ERR(parent);
   120		} else if (!parent) {
 > 121			drm_debug(&gt->i915->drm, "Not enough engines in class: %d", class);
   122			return 0;
   123		}
   124	
   125		rq = multi_lrc_nop_request(parent);
   126		if (IS_ERR(rq)) {
   127			ret = PTR_ERR(rq);
   128			drm_err(&gt->i915->drm, "Failed creating requests: %d", ret);
   129			goto out;
   130		}
   131	
   132		ret = intel_selftest_wait_for_rq(rq);
   133		if (ret)
   134			drm_err(&gt->i915->drm, "Failed waiting on request: %d", ret);
   135	
   136		i915_request_put(rq);
   137	
   138		if (ret >= 0) {
   139			ret = intel_gt_wait_for_idle(gt, HZ * 5);
   140			if (ret < 0)
   141				drm_err(&gt->i915->drm, "GT failed to idle: %d\n", ret);
   142		}
   143	
   144	out:
   145		multi_lrc_context_unpin(parent);
   146		multi_lrc_context_put(parent);
   147		return ret;
   148	}
   149	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp