On Mon, 2022-06-06 at 17:56 +0530, Anshuman Gupta wrote: > Currently i915 disables d3cold for i915 pci dev. > This blocks D3 for i915 gfx pci upstream bridge (VSP). > Let's disable d3cold at gfx root port to make sure that > i915 gfx VSP can transition to D3 to save some power. (nit) It's better to use imperative in the commit message, so "Disable d3cold at gfx root port..." would be easier to read. Also, from the code, it's clear that you're disabling d3cold in the root now, instead of in the pdev itself. But you don't explain why you moved the enabling/disabling to hw_probe and remove_hw from the actual PM calls... -- Cheers, Luca.
