On Thu, May 26, 2022 at 12:00:42PM -0700, Ashutosh Dixit wrote: > Create a gt/gtN/.defaults directory (similar to > engine/<engine-name>/.defaults) to expose default parameter values for each > gt in sysfs. This allows userspace to restore default parameter values > after they may have changed. Drive-by comment: since this is a GT-related change, I think we're required to Cc: dri-devel as well. And since this is new ABI, we'd need an open source userspace consumer or a very clear explanation why this is an exception to the rule (e.g., if these are meant to be twiddled directly by the user rather than accessed by userspace software). Matt > > Patch 1: Creates the gt/gtN/.defaults directory > Patch 2: Adds per-gt RPS defaults to gt/gtN/.defaults > Patch 3: Adds media_freq_factor to gt/gtN/.defaults > > Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxxxxxxxx> > Cc: Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx> > Signed-off-by: Ashutosh Dixit <ashutosh.dixit@xxxxxxxxx> > > Ashutosh Dixit (3): > drm/i915/gt: Create gt/gtN/.defaults for per gt sysfs defaults > drm/i915/gt: Expose per-gt RPS defaults in sysfs > drm/i915/gt: Expose default value for media_freq_factor in per-gt > sysfs > > drivers/gpu/drm/i915/gt/intel_gt_sysfs.c | 10 ++-- > drivers/gpu/drm/i915/gt/intel_gt_sysfs.h | 6 ++ > drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 64 +++++++++++++++++++++ > drivers/gpu/drm/i915/gt/intel_gt_types.h | 11 ++++ > drivers/gpu/drm/i915/gt/intel_rps.c | 3 + > drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 19 ++++-- > 6 files changed, 103 insertions(+), 10 deletions(-) > > -- > 2.34.1 > -- Matt Roper Graphics Software Engineer VTT-OSGC Platform Enablement Intel Corporation
