On 12/05/2022 05:38, Dixit, Ashutosh wrote:
On Wed, 11 May 2022 19:32:13 -0700, Ashutosh Dixit wrote:
Some recent Intel dGfx platforms allow media IP to work at a different
frequency from the base GT. This patch series exposes sysfs controls for
this functionality in the new per-gt sysfs. Some enhancements and fixes to
previous per-gt functionality are also included to complete the new
functionality:
* Patches 1 and 2 implement basic sysfs controls for media freq
* Patch 3 extends previous pcode functions for multiple gt's
* Patch 4 inits pcode on different gt's
* Patch 5 adds a couple of pcode helpers
* Patch 6 uses the new pcode functions to retrieve media RP0/RPn freq
* Patch 7 fixes memory leaks in the previous per-gt sysfs implementation
and some code refactoring
In this v5 I have dropped the last two patches of the v4 series, these
ones:
[PATCH 7/8] drm/i915/gt: Expose per-gt RPS defaults in sysfs
[PATCH 8/8] drm/i915/gt: Expose default value for media_freq_factor in per-gt sysfs
Because these need more work based on the review comments. If this series
is merged I will submit these patches as a separate series, otherwise I
will re-add them to this series and resubmit (due to dependence between
this series and those patches).
Apart from this, I believe I have addressed all previous review comments on
the patches in this series.
Thanks for reviewing,
Acked-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
At some point we should starting documenting our sysfs in
Documentation/ABI. For instance the freq ratio this patch adds really
does need some user facing docs to know how to use it. Would you sign up
to document the bits this series adds as follow up?
Regards,
Tvrtko
