Re: [PATCH 2/8] drm/i915/gt: Add media freq factor to per-gt sysfs

["Dixit, Ashutosh" <ashutosh.dixit@xxxxxxxxx>]

On Tue, 10 May 2022 00:24:02 -0700, Tvrtko Ursulin wrote:
>
> > @@ -598,4 +720,12 @@ void intel_gt_sysfs_pm_init(struct intel_gt *gt, struct kobject *kobj)
> >		drm_warn(&gt->i915->drm,
> >			 "failed to create gt%u throttle sysfs files (%pe)",
> >			 gt->info.id, ERR_PTR(ret));
> > +
> > +	if (HAS_MEDIA_RATIO_MODE(gt->i915) && intel_uc_uses_guc_slpc(&gt->uc)) {
> > +		ret = sysfs_create_files(kobj, media_perf_power_attrs);
> > +		if (ret)
> > +			drm_warn(&gt->i915->drm,
> > +				 "failed to create add gt%u media_perf_power_attrs sysfs (%pe)\n",
>
> Nit - "create add" - pick one?

Fixed in Patch v2 (Series v5).