Hi Ashutosh, On Fri, Apr 29, 2022 at 12:56:24PM -0700, Ashutosh Dixit wrote: > Each gt contains an independent instance of pcode. Extend pcode functions > to interface with pcode on different gt's. To avoid creating dependency of > display functionality on intel_gt, pcode function interfaces are exposed in > terms of uncore rather than intel_gt. Callers have been converted to pass > in the appropritate (i915 or intel_gt) uncore to the pcode functions. > > v2: Expose pcode functions in terms of uncore rather than gt (Jani/Rodrigo) > v3: Retain previous function names to eliminate needless #defines (Rodrigo) > > Cc: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> > Cc: Jani Nikula <jani.nikula@xxxxxxxxx> > Cc: Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx> > Signed-off-by: Ashutosh Dixit <ashutosh.dixit@xxxxxxxxx> looks correct: Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx> Thanks, Andi