== Series Details == Series: i915: Introduce Ponte Vecchio (rev3) URL : https://patchwork.freedesktop.org/series/103443/ State : warning == Summary == Error: dim checkpatch failed d831d43de27e drm/i915/uncore: Reorganize and document shadow and forcewake tables -:82: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'offset' - possible side-effects? #82: FILE: drivers/gpu/drm/i915/intel_uncore.c:1106: +#define __fwtable_reg_read_fw_domains(uncore, offset) \ +({ \ + enum forcewake_domains __fwd = 0; \ + if (NEEDS_FORCE_WAKE((offset))) \ + __fwd = find_fw_domain(uncore, offset); \ + __fwd; \ +}) -:90: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'uncore' - possible side-effects? #90: FILE: drivers/gpu/drm/i915/intel_uncore.c:1114: +#define __fwtable_reg_write_fw_domains(uncore, offset) \ +({ \ + enum forcewake_domains __fwd = 0; \ + const u32 __offset = (offset); \ + if (NEEDS_FORCE_WAKE((__offset)) && !is_shadowed(uncore, __offset)) \ + __fwd = find_fw_domain(uncore, __offset); \ + __fwd; \ +}) -:147: CHECK:LINE_SPACING: Please don't use multiple blank lines #147: FILE: drivers/gpu/drm/i915/intel_uncore.c:1170: + + total: 0 errors, 0 warnings, 3 checks, 172 lines checked 50c88acae6ba drm/i915/pvc: Add forcewake support -:80: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #80: FILE: drivers/gpu/drm/i915/intel_uncore.c:1576: + GEN_FW_RANGE(0x4000, 0x813f, FORCEWAKE_GT), /* + 0x4000 - 0x4aff: gt -:86: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #86: FILE: drivers/gpu/drm/i915/intel_uncore.c:1582: + 0x8000 - 0x813f: gt */ -:90: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #90: FILE: drivers/gpu/drm/i915/intel_uncore.c:1586: + GEN_FW_RANGE(0x8200, 0x94cf, FORCEWAKE_GT), /* + 0x8200 - 0x82ff: gt -:97: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #97: FILE: drivers/gpu/drm/i915/intel_uncore.c:1593: + 0x9480 - 0x94cf: reserved */ -:100: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #100: FILE: drivers/gpu/drm/i915/intel_uncore.c:1596: + GEN_FW_RANGE(0x9560, 0x967f, 0), /* + 0x9560 - 0x95ff: always on -:101: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #101: FILE: drivers/gpu/drm/i915/intel_uncore.c:1597: + 0x9600 - 0x967f: reserved */ -:103: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #103: FILE: drivers/gpu/drm/i915/intel_uncore.c:1599: + GEN_FW_RANGE(0x9680, 0x97ff, FORCEWAKE_RENDER), /* + 0x9680 - 0x96ff: render -:104: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #104: FILE: drivers/gpu/drm/i915/intel_uncore.c:1600: + 0x9700 - 0x97ff: reserved */ -:106: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #106: FILE: drivers/gpu/drm/i915/intel_uncore.c:1602: + GEN_FW_RANGE(0x9800, 0xcfff, FORCEWAKE_GT), /* + 0x9800 - 0xb4ff: gt -:108: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #108: FILE: drivers/gpu/drm/i915/intel_uncore.c:1604: + 0xc000 - 0xcfff: gt */ -:113: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #113: FILE: drivers/gpu/drm/i915/intel_uncore.c:1609: + GEN_FW_RANGE(0xdd00, 0xde7f, FORCEWAKE_GT), /* + 0xdd00 - 0xddff: gt -:114: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #114: FILE: drivers/gpu/drm/i915/intel_uncore.c:1610: + 0xde00 - 0xde7f: reserved */ -:116: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #116: FILE: drivers/gpu/drm/i915/intel_uncore.c:1612: + GEN_FW_RANGE(0xde80, 0xe8ff, FORCEWAKE_RENDER), /* + 0xde80 - 0xdeff: render -:119: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #119: FILE: drivers/gpu/drm/i915/intel_uncore.c:1615: + 0xe800 - 0xe8ff: reserved */ -:121: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #121: FILE: drivers/gpu/drm/i915/intel_uncore.c:1617: + GEN_FW_RANGE(0xe900, 0x11fff, FORCEWAKE_GT), /* + 0xe900 - 0xe9ff: gt -:124: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #124: FILE: drivers/gpu/drm/i915/intel_uncore.c:1620: + 0x10000 - 0x11fff: reserved */ -:126: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #126: FILE: drivers/gpu/drm/i915/intel_uncore.c:1622: + GEN_FW_RANGE(0x12000, 0x12fff, 0), /* + 0x12000 - 0x127ff: always on -:127: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #127: FILE: drivers/gpu/drm/i915/intel_uncore.c:1623: + 0x12800 - 0x12fff: reserved */ -:129: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #129: FILE: drivers/gpu/drm/i915/intel_uncore.c:1625: + GEN_FW_RANGE(0x13000, 0x23fff, FORCEWAKE_GT), /* + 0x13000 - 0x135ff: gt -:135: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #135: FILE: drivers/gpu/drm/i915/intel_uncore.c:1631: + 0x22000 - 0x23fff: gt */ -:137: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #137: FILE: drivers/gpu/drm/i915/intel_uncore.c:1633: + GEN_FW_RANGE(0x24000, 0x2417f, 0), /* + 24000 - 0x2407f: always on -:138: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #138: FILE: drivers/gpu/drm/i915/intel_uncore.c:1634: + 24080 - 0x2417f: reserved */ -:140: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #140: FILE: drivers/gpu/drm/i915/intel_uncore.c:1636: + GEN_FW_RANGE(0x24180, 0x3ffff, FORCEWAKE_GT), /* + 0x24180 - 0x241ff: gt -:146: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #146: FILE: drivers/gpu/drm/i915/intel_uncore.c:1642: + 0x30000 - 0x3ffff: gt */ -:149: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #149: FILE: drivers/gpu/drm/i915/intel_uncore.c:1645: + GEN_FW_RANGE(0x1c0000, 0x1c3fff, FORCEWAKE_MEDIA_VDBOX0), /* + 0x1c0000 - 0x1c2bff: VD0 -:153: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #153: FILE: drivers/gpu/drm/i915/intel_uncore.c:1649: + 0x1c3f00 - 0x1c3fff: VD0 */ -:155: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #155: FILE: drivers/gpu/drm/i915/intel_uncore.c:1651: + GEN_FW_RANGE(0x1c4000, 0x1cffff, FORCEWAKE_MEDIA_VDBOX1), /* + 0x1c4000 - 0x1c6aff: VD1 -:158: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #158: FILE: drivers/gpu/drm/i915/intel_uncore.c:1654: + 0x1c8000 - 0x1cffff: reserved */ -:160: WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #160: FILE: drivers/gpu/drm/i915/intel_uncore.c:1656: + GEN_FW_RANGE(0x1d0000, 0x23ffff, FORCEWAKE_MEDIA_VDBOX2), /* + 0x1d0000 - 0x1d2aff: VD2 -:163: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #163: FILE: drivers/gpu/drm/i915/intel_uncore.c:1659: + 0x1d4000 - 0x23ffff: reserved */ total: 0 errors, 30 warnings, 0 checks, 174 lines checked 40c3eaf4f764 drm/i915/pvc: Define MOCS table for PVC ade610619555 drm/i915/pvc: Read correct RP_STATE_CAP register 188a768080c9 drm/i915/pvc: Remove additional 3D flags from PIPE_CONTROL -:69: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #69: FILE: drivers/gpu/drm/i915/gt/intel_gpu_commands.h:292: +#define PIPE_CONTROL_3D_ENGINE_FLAGS (\ PIPE_CONTROL_RENDER_TARGET_CACHE_FLUSH | \ PIPE_CONTROL_DEPTH_CACHE_FLUSH | \ PIPE_CONTROL_TILE_CACHE_FLUSH | \ total: 1 errors, 0 warnings, 0 checks, 86 lines checked 7e31d86b188b drm/i915/pvc: Reduce stack usage in reset selftest with extra blitter engine c500a6bf46a8 drm/i915/gvt: Use intel_engine_mask_t for ring mask ec0b13cb48ee drm/i915/pvc: Engine definitions for new copy engines 6c3af6101f6e drm/i915/pvc: Interrupt support for new copy engines 556728d14e82 drm/i915/pvc: Reset support for new copy engines 6a175c5f9c71 drm/i915/pvc: skip all copy engines from aux table invalidate 9685f669e4b4 drm/i915/pvc: read fuses for link copy engines
