On Thu, Apr 28, 2022 at 05:39:43PM -0700, Ashutosh Dixit wrote: > Add the following sysfs file to gt/gtN/.defaults: > * media_freq_factor > > Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> > Cc: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> > Signed-off-by: Ashutosh Dixit <ashutosh.dixit@xxxxxxxxx> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> > --- > drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 18 ++++++++++++++++++ > drivers/gpu/drm/i915/gt/intel_gt_types.h | 1 + > drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 2 ++ > 3 files changed, 21 insertions(+) > > diff --git a/drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c b/drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c > index bbf49613ecd0..3c84731e0eca 100644 > --- a/drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c > +++ b/drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c > @@ -759,6 +759,18 @@ default_boost_freq_mhz_show(struct kobject *kobj, struct kobj_attribute *attr, c > static struct kobj_attribute default_boost_freq_mhz = > __ATTR(rps_boost_freq_mhz, 0444, default_boost_freq_mhz_show, NULL); > > +static ssize_t > +default_media_freq_factor_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf) > +{ > + struct intel_gt *gt = kobj_to_gt(kobj->parent); > + > + return sysfs_emit(buf, "%d\n", > + media_ratio_mode_to_factor(gt->rps_defaults.media_ratio_mode)); > +} > + > +static struct kobj_attribute default_media_freq_factor = > +__ATTR(media_freq_factor, 0444, default_media_freq_factor_show, NULL); > + > static const struct attribute * const rps_defaults_attrs[] = { > &default_min_freq_mhz.attr, > &default_max_freq_mhz.attr, > @@ -819,6 +831,12 @@ void intel_gt_sysfs_pm_init(struct intel_gt *gt, struct kobject *kobj) > drm_warn(>->i915->drm, > "failed to create add gt%u media_perf_power_attrs sysfs (%pe)\n", > gt->info.id, ERR_PTR(ret)); > + > + ret = sysfs_create_file(gt->sysfs_defaults, &default_media_freq_factor.attr); > + if (ret) > + drm_warn(>->i915->drm, > + "failed to add gt%u default_media_freq_factor sysfs (%pe)\n", > + gt->info.id, ERR_PTR(ret)); > } > > ret = add_rps_defaults(gt); > diff --git a/drivers/gpu/drm/i915/gt/intel_gt_types.h b/drivers/gpu/drm/i915/gt/intel_gt_types.h > index 8b696669b846..07d368ca78ca 100644 > --- a/drivers/gpu/drm/i915/gt/intel_gt_types.h > +++ b/drivers/gpu/drm/i915/gt/intel_gt_types.h > @@ -66,6 +66,7 @@ struct intel_rps_defaults { > u32 min_freq; > u32 max_freq; > u32 boost_freq; > + u32 media_ratio_mode; > }; > > enum intel_submission_method { > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c > index cefd864c84eb..047c80838fcd 100644 > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c > @@ -260,7 +260,9 @@ int intel_guc_slpc_init(struct intel_guc_slpc *slpc) > slpc->boost_freq = 0; > atomic_set(&slpc->num_waiters, 0); > slpc->num_boosts = 0; > + > slpc->media_ratio_mode = SLPC_MEDIA_RATIO_MODE_DYNAMIC_CONTROL; > + slpc_to_gt(slpc)->rps_defaults.media_ratio_mode = slpc->media_ratio_mode; > > mutex_init(&slpc->lock); > INIT_WORK(&slpc->boost_work, slpc_boost_work); > -- > 2.34.1 >