On Sun, 24 Apr 2022 15:05:47 -0700, Andi Shyti wrote:
>
> Hi Ashutosh,
>
> [...]
>
> > +static ssize_t media_RP0_freq_mhz_show(struct device *dev,
> > + struct device_attribute *attr,
> > + char *buff)
> > +{
> > + struct intel_gt *gt = intel_gt_sysfs_get_drvdata(dev, attr->attr.name);
> > + u32 val;
> > + int err;
> > +
> > + err = __intel_gt_pcode_read(gt, XEHPSDV_PCODE_FREQUENCY_CONFIG,
> > + PCODE_MBOX_FC_SC_READ_FUSED_P0,
> > + PCODE_MBOX_DOMAIN_MEDIAFF, &val);
> > +
> > + if (err)
> > + return err;
> > +
> > + /* data_out - Fused P0 for domain ID in units of 50 MHz */
>
> this comment doesn't say much, can we make it a bit clearer? The
> same for the one below.
Hopefully I've made it a bit clearer in v3.
>
> The rest looks good:
>
> Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx>
Retaining the R-b, since change in v3 is just s/gt/gt->uncore/.
