Hi Ashutosh, > > > -static struct kobj_type kobj_gt_type = { > > > - .release = kobj_gt_release, > > > +static struct kobj_type kobj_gtn_type = { > > > > what does it mean GTN? Or is it GTn? Please use just GT, gtn is > > confusing. > > > > Same for all the rest of the gtn's you have used below. > > I didn't like gtn either. But a sysfs_gt kobject is already part of 'struct > drm_i915_private' so I thought I'll put sysfs_gtn (for gt/gtN) in 'struct > intel_gt'. Otherwise browsing the code etc. gets confusing. we can even use 'gt_n' if the 'n' is really necessary. Andi