On Mon, 25 Apr 2022 02:39:42 -0700, Kamil Konieczny wrote: > > Hi Ashutosh, Hi Kamil, > On 2022-04-13 at 11:11:06 -0700, Ashutosh Dixit wrote: > > Retrieve RP0 and RPn freq for media IP from PCODE and display in per-gt > > sysfs. This patch adds the following files to gt/gtN sysfs: > > * media_RP0_freq_mhz > > * media_RPn_freq_mhz > --------- ^ > Can we keep it in lowercase ? So it will be like: > media_rp0_freq_mhz > media_rpn_freq_mhz > > Or is it merged with capital letters at other sysfs path ? Unfortunately that is the case as we can see below: $ ls -l /sys/class/drm/card0/gt/gt0/rps* -r--r--r-- 1 root root 4096 Jan 20 19:55 rps_RP0_freq_mhz -r--r--r-- 1 root root 4096 Jan 20 19:55 rps_RP1_freq_mhz -r--r--r-- 1 root root 4096 Jan 20 19:55 rps_RPn_freq_mhz We could have have discussed it before the other RPS patches were merged but I think at this point we'd need to maintain consistency with the previous naming scheme (the frequencies are actually known as RP0/RPn). Thanks. -- Ashutosh
