On Thu, 21 Apr 2022 13:57:03 -0700, Rodrigo Vivi wrote: > > On Tue, Apr 19, 2022 at 10:21:26PM -0700, Ashutosh Dixit wrote: > > > +#define U8_8_VAL_MASK 0xffff > > +#define U8_8_SCALE_TO_VALUE "0.00390625" > > I really like this style because it gets future proof... > Well, honestly I don't believe that for Media multipliers we will be ever > move away from the GuC API. Nevertheless we have other cases in the pipeline > like balancing the gt and basedie that benefits of this abstraction and > it is good to have a standard api and in sync. > > For this reason I'm in favor of this one here and code looks correct to me, > so: > > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> Thanks. > Should we split this series with only this 2 first patches so we don't > get blocked on the intel_pcode refactor? I have posted a series with with just the first 2 patches here: https://patchwork.freedesktop.org/series/103110/ We can look at merging this after it goes through CI. Thanks. -- Ashutosh
