On Wed, Apr 13, 2022 at 06:28:51PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
>
> plane_state->uapi.crtc is not what we want to be looking at.
> If bigjoiner is used hw.crtc is what tells us what crtc the plane
> is supposedly using.
>
> Not an actual problem on current hardware as the only FBC capable
> pipe (A) can't be a bigjoiner slave and thus uapi.crtc==hw.crtc
> always here. But when we get more FBC instances this will become
> actually important.
>
> Fixes: 2e6c99f88679 ("drm/i915/fbc: Nuke lots of crap from intel_fbc_state_cache")
> Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
Reviewed-by: Manasi Navare <manasi.d.navare@xxxxxxxxx>
Manasi
> ---
> drivers/gpu/drm/i915/display/intel_fbc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c
> index 670835318a1f..ff303c7d3a57 100644
> --- a/drivers/gpu/drm/i915/display/intel_fbc.c
> +++ b/drivers/gpu/drm/i915/display/intel_fbc.c
> @@ -1045,7 +1045,7 @@ static int intel_fbc_check_plane(struct intel_atomic_state *state,
> struct intel_plane_state *plane_state =
> intel_atomic_get_new_plane_state(state, plane);
> const struct drm_framebuffer *fb = plane_state->hw.fb;
> - struct intel_crtc *crtc = to_intel_crtc(plane_state->uapi.crtc);
> + struct intel_crtc *crtc = to_intel_crtc(plane_state->hw.crtc);
> const struct intel_crtc_state *crtc_state;
> struct intel_fbc *fbc = plane->fbc;
>
> --
> 2.35.1
>
