== Series Details == Series: drm/i915/display: Communicate display configuration to pcode URL : https://patchwork.freedesktop.org/series/102678/ State : warning == Summary == Error: dim checkpatch failed a4a6dfddbdd5 drm/i915/display: Communicate display configuration to pcode -:66: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #66: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:2074: +static void intel_display_to_pcode(struct drm_i915_private *dev_priv, + unsigned int cdclk, u8 voltage_level, -:80: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #80: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:2088: + drm_err(&dev_priv->drm, + "Failed to inform PCU about display config (err %d)\n", -:107: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'new_cdclk_state->active_pipes == old_cdclk_state->active_pipes' #107: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:2177: + if (!intel_cdclk_changed(&old_cdclk_state->actual, + &new_cdclk_state->actual) && + (new_cdclk_state->active_pipes == + old_cdclk_state->active_pipes)) -:108: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #108: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:2178: + if (!intel_cdclk_changed(&old_cdclk_state->actual, + &new_cdclk_state->actual) && -:114: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #114: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:2184: + intel_display_to_pcode(dev_priv, new_cdclk_state->actual.cdclk, + new_cdclk_state->actual.voltage_level, -:120: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #120: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:2190: + intel_display_to_pcode(dev_priv, old_cdclk_state->actual.cdclk, + old_cdclk_state->actual.voltage_level, -:126: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #126: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:2196: + intel_display_to_pcode(dev_priv, new_cdclk_state->actual.cdclk, + new_cdclk_state->actual.voltage_level, -:131: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #131: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:2201: + intel_display_to_pcode(dev_priv, DISPLAY_TO_PCODE_CDCLK_MAX, + new_cdclk_state->actual.voltage_level, -:145: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #145: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:2215: + intel_display_to_pcode(dev_priv, new_cdclk_state->actual.cdclk, + new_cdclk_state->actual.voltage_level, -:198: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'cdclk' may be better as '(cdclk)' to avoid precedence issues #198: FILE: drivers/gpu/drm/i915/i915_reg.h:6721: +#define DISPLAY_TO_PCODE_MASK(cdclk, num_pipes, voltage_level) \ + ((1 << 31) | (num_pipes << 28) | \ + (cdclk << 16) | (1 << 27) | voltage_level) -:198: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'num_pipes' may be better as '(num_pipes)' to avoid precedence issues #198: FILE: drivers/gpu/drm/i915/i915_reg.h:6721: +#define DISPLAY_TO_PCODE_MASK(cdclk, num_pipes, voltage_level) \ + ((1 << 31) | (num_pipes << 28) | \ + (cdclk << 16) | (1 << 27) | voltage_level) -:198: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'voltage_level' may be better as '(voltage_level)' to avoid precedence issues #198: FILE: drivers/gpu/drm/i915/i915_reg.h:6721: +#define DISPLAY_TO_PCODE_MASK(cdclk, num_pipes, voltage_level) \ + ((1 << 31) | (num_pipes << 28) | \ + (cdclk << 16) | (1 << 27) | voltage_level) total: 0 errors, 0 warnings, 12 checks, 165 lines checked
