On Wed, Apr 13, 2022 at 11:03:05AM -0300, Jason Gunthorpe wrote: > On Wed, Apr 13, 2022 at 08:11:05AM +0200, Christoph Hellwig wrote: > > On Tue, Apr 12, 2022 at 12:53:36PM -0300, Jason Gunthorpe wrote: > > > + if (WARN_ON(!READ_ONCE(vdev->open_count))) > > > + return -EINVAL; > > > > I think all the WARN_ON()s in this patch need to be WARN_ON_ONCE, > > otherwise there will be too many backtraces to be useful if a driver > > ever gets the API wrong. > > Sure, I added a wrapper to make that have less overhead and merged it > with the other 'driver is calling this correctly' checks: Looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
