== Series Details == Series: Make the rest of the VFIO driver interface use vfio_device URL : https://patchwork.freedesktop.org/series/102606/ State : warning == Summary == Error: dim checkpatch failed 1a0dcd52cf62 vfio: Make vfio_(un)register_notifier accept a vfio_device -:33: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #33: FILE: drivers/gpu/drm/i915/gvt/kvmgt.c:919: + ret = vfio_register_notifier(vfio_dev, VFIO_IOMMU_NOTIFY, &events, &vdev->iommu_notifier); -:42: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #42: FILE: drivers/gpu/drm/i915/gvt/kvmgt.c:928: + ret = vfio_register_notifier(vfio_dev, VFIO_GROUP_NOTIFY, &events, &vdev->group_notifier); -:51: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #51: FILE: drivers/gpu/drm/i915/gvt/kvmgt.c:966: + vfio_unregister_notifier(vfio_dev, VFIO_GROUP_NOTIFY, &vdev->group_notifier); -:56: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #56: FILE: drivers/gpu/drm/i915/gvt/kvmgt.c:970: + vfio_unregister_notifier(vfio_dev, VFIO_IOMMU_NOTIFY, &vdev->iommu_notifier); -:74: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #74: FILE: drivers/gpu/drm/i915/gvt/kvmgt.c:1005: + ret = vfio_unregister_notifier(vfio_dev, VFIO_IOMMU_NOTIFY, &vdev->iommu_notifier); -:80: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #80: FILE: drivers/gpu/drm/i915/gvt/kvmgt.c:1010: + ret = vfio_unregister_notifier(vfio_dev, VFIO_GROUP_NOTIFY, &vdev->group_notifier); -:268: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #268: FILE: include/linux/vfio.h:181: +extern int vfio_register_notifier(struct vfio_device *dev, -:273: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #273: FILE: include/linux/vfio.h:185: +extern int vfio_unregister_notifier(struct vfio_device *dev, -:276: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jason Gunthorpe <jgg@xxxxxxxx>' != 'Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxx>' total: 0 errors, 1 warnings, 8 checks, 217 lines checked 6895636f3f14 vfio/ccw: Remove mdev from struct channel_program -:206: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #206: FILE: drivers/s390/cio/vfio_ccw_cp.h:44: +extern int cp_init(struct channel_program *cp, union orb *orb); -:223: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jason Gunthorpe <jgg@xxxxxxxx>' != 'Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxx>' total: 0 errors, 1 warnings, 1 checks, 183 lines checked a49bf1b00724 vfio/mdev: Pass in a struct vfio_device * to vfio_pin/unpin_pages() -:209: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #209: FILE: include/linux/vfio.h:153: +extern int vfio_pin_pages(struct vfio_device *vdev, unsigned long *user_pfn, -:212: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #212: FILE: include/linux/vfio.h:155: +extern int vfio_unpin_pages(struct vfio_device *vdev, unsigned long *user_pfn, -:215: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jason Gunthorpe <jgg@xxxxxxxx>' != 'Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxx>' total: 0 errors, 1 warnings, 2 checks, 169 lines checked 3c71cd007be5 drm/i915/gvt: Change from vfio_group_(un)pin_pages to vfio_(un)pin_pages -:52: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jason Gunthorpe <jgg@xxxxxxxx>' != 'Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 32 lines checked 868856efe678 vfio: Pass in a struct vfio_device * to vfio_dma_rw() -:24: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #24: FILE: drivers/gpu/drm/i915/gvt/kvmgt.c:2187: + return vfio_dma_rw( -:93: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #93: FILE: include/linux/vfio.h:164: +extern int vfio_dma_rw(struct vfio_device *vdev, dma_addr_t user_iova, -:96: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jason Gunthorpe <jgg@xxxxxxxx>' != 'Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxx>' total: 0 errors, 1 warnings, 2 checks, 67 lines checked 197e48b986e6 drm/i915/gvt: Add missing module_put() in error unwind -:34: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jason Gunthorpe <jgg@xxxxxxxx>' != 'Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 17 lines checked f2ddbd56fbfa drm/i915/gvt: Delete kvmgt_vdev::vfio_group -:70: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jason Gunthorpe <jgg@xxxxxxxx>' != 'Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 52 lines checked adaa03d8ab38 vfio: Remove dead code -:224: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jason Gunthorpe <jgg@xxxxxxxx>' != 'Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 195 lines checked 77d787fcf640 vfio: Remove calls to vfio_group_add_container_user() -:199: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jason Gunthorpe <jgg@xxxxxxxx>' != 'Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 156 lines checked
