Re: [PATCH 5/9] vfio: Pass in a struct vfio_device * to vfio_dma_rw()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 5/9] vfio: Pass in a struct vfio_device * to vfio_dma_rw()
From: Christoph Hellwig <hch@xxxxxx>
Date: Wed, 13 Apr 2022 08:00:08 +0200
Cc: kvm@xxxxxxxxxxxxxxx, linux-doc@xxxxxxxxxxxxxxx, David Airlie <airlied@xxxxxxxx>, dri-devel@xxxxxxxxxxxxxxxxxxxxx, Kirti Wankhede <kwankhede@xxxxxxxxxx>, Vineeth Vijayan <vneethv@xxxxxxxxxxxxx>, Alexander Gordeev <agordeev@xxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, linux-s390@xxxxxxxxxxxxxxx, "Liu, Yi L" <yi.l.liu@xxxxxxxxx>, Matthew Rosato <mjrosato@xxxxxxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, Halil Pasic <pasic@xxxxxxxxxxxxx>, Christian Borntraeger <borntraeger@xxxxxxxxxxxxx>, intel-gfx@xxxxxxxxxxxxxxxxxxxxx, Jason Herne <jjherne@xxxxxxxxxxxxx>, Eric Farman <farman@xxxxxxxxxxxxx>, Vasily Gorbik <gor@xxxxxxxxxxxxx>, Heiko Carstens <hca@xxxxxxxxxxxxx>, Harald Freudenberger <freude@xxxxxxxxxxxxx>, Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>, intel-gvt-dev@xxxxxxxxxxxxxxxxxxxxx, Tony Krowiak <akrowiak@xxxxxxxxxxxxx>, Cornelia Huck <cohuck@xxxxxxxxxx>, Peter Oberparleiter <oberpar@xxxxxxxxxxxxx>, Sven Schnelle <svens@xxxxxxxxxxxxx>
In-reply-to: <5-v1-a8faf768d202+125dd-vfio_mdev_no_group_jgg@nvidia.com>
References: <0-v1-a8faf768d202+125dd-vfio_mdev_no_group_jgg@nvidia.com> <5-v1-a8faf768d202+125dd-vfio_mdev_no_group_jgg@nvidia.com>
User-agent: Mutt/1.5.17 (2007-11-01)

This looks good execept the extern nitpick:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

However I'd move this before the previous patch.  More of the explanation
there.

Follow-Ups:
- Re: [PATCH 5/9] vfio: Pass in a struct vfio_device * to vfio_dma_rw()
  - From: Jason Gunthorpe

References:
- [PATCH 0/9] Make the rest of the VFIO driver interface use vfio_device
  - From: Jason Gunthorpe
- [PATCH 5/9] vfio: Pass in a struct vfio_device * to vfio_dma_rw()
  - From: Jason Gunthorpe

Prev by Date: Re: [PATCH 6/9] drm/i915/gvt: Add missing module_put() in error unwind
Next by Date: Re: [PATCH 4/9] drm/i915/gvt: Change from vfio_group_(un)pin_pages to vfio_(un)pin_pages
Previous by thread: [PATCH 5/9] vfio: Pass in a struct vfio_device * to vfio_dma_rw()
Next by thread: Re: [PATCH 5/9] vfio: Pass in a struct vfio_device * to vfio_dma_rw()
Index(es):
- Date
- Thread

[Index of Archives] [AMD Graphics] [Linux USB Devel] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI]