On Wed, 06 Apr 2022 03:09:45 -0700, Anshuman Gupta wrote: > On 2022-03-24 at 01:24:35 +0530, Ashutosh Dixit wrote: > > +/* "Caps" frequencies should be converted to MHz using intel_gpu_freq() */ > IMHO, if this exported function deserves a comment, it should Kernel Doc comment. > for an example see Doc comment of intel_runtime_pm_get_raw(). > Thanks, > Anshuman Gupta. > > +void gen6_rps_get_freq_caps(struct intel_rps *rps, struct intel_rps_freq_caps *caps) I have changed the comments to kernel doc for both gen6_rps_get_freq_caps() and 'struct intel_rps_freq_caps' in v5 (v6 in Patchwork). Please take a look. Thanks.