On Thu, 31 Mar 2022, Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx> wrote:
> On Thu, 31 Mar 2022, Ville Syrjala <ville.syrjala@xxxxxxxxxxxxxxx> wrote:
>> diff --git a/drivers/gpu/drm/i915/display/intel_drrs.c b/drivers/gpu/drm/i915/display/intel_drrs.c
>> index 1448c3029b8e..8fd280c7c83f 100644
>> --- a/drivers/gpu/drm/i915/display/intel_drrs.c
>> +++ b/drivers/gpu/drm/i915/display/intel_drrs.c
>> @@ -358,7 +358,6 @@ void intel_crtc_drrs_init(struct intel_crtc *crtc)
>> /**
>> * intel_drrs_init - Init DRRS for eDP connector
>> * @connector: eDP connector
>> - * @fixed_mode: preferred mode of panel
>> *
>> * This function is called only once at driver load to initialize
>> * DRRS support for the connector.
>> @@ -368,25 +367,14 @@ void intel_crtc_drrs_init(struct intel_crtc *crtc)
>> * DRRS support is determined by the presence of downclock mode (apart
>> * from VBT setting).
>> */
>> -struct drm_display_mode *
>> -intel_drrs_init(struct intel_connector *connector,
>> - const struct drm_display_mode *fixed_mode)
>> +void intel_drrs_init(struct intel_connector *connector)
>> {
>> struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
>> - struct drm_display_mode *downclock_mode;
>> -
>> - downclock_mode = intel_panel_edid_downclock_mode(connector, fixed_mode);
>> - if (!downclock_mode) {
>> - drm_dbg_kms(&dev_priv->drm,
>> - "[CONNECTOR:%d:%s] DRRS not supported due to lack of downclock mode\n",
>> - connector->base.base.id, connector->base.name);
>> - return NULL;
>> - }
>> +
>> + intel_panel_add_edid_downclock_mode(connector);
>
> What if there's no downclock mode, just one native mode with one
> vrefresh? We'll now now say drrs type is this or that below, but it'll
> never get enabled in compute config?
>
> Should intel_panel_add_edid_downclock_mode() debug log when there's no
> downclock mode?
Other than that, nice cleanups all over the place,
Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx>
--
Jani Nikula, Intel Open Source Graphics Center
