On Tue, Mar 29, 2022 at 05:00:39PM -0700, Navare, Manasi wrote: > Hi Ville, > > I was looking at your suggestion of extracting the per pipe stuff out. > Currently in hsw_crtc_enable: the Only non per pipe stuff which gets enabled for the encoders is : > encoder specific is pre_pll_enable(), enable_shared_dpll, encoders_pre_enable and configure_cpu_transcoder() - All of this > can be put in a function hsw_encoder_configure() or something that can still be called from with hsw_crtc_enable I don't see a need to move that stuff anywhere. Just leave it in hsw_crtc_enable() IMO. > > Then the remaining can go into a per pipe function that can be called for each slave pipe This is what I have been suggesting. But I think there's also some per-pipe stuff currently in the the encoder hooks, and some of that is only done for the master there whereaas the slave part I think are somewhere else. We should attempt to fix that as well so that every step is done in a consistent manner for every pipe be it master or slave. -- Ville Syrjälä Intel
