On Fri, Mar 25, 2022 at 08:10:59PM +0200, Ville Syrjälä wrote:
> On Fri, Mar 25, 2022 at 08:34:36AM -0700, José Roberto de Souza wrote:
> > intel_drrs_enable and intel_drrs_disable where renamed to
> > intel_drrs_activate and intel_drrs_deactivate in commit
> > 54903c7a6b40 ("drm/i915: s/enable/active/ for DRRS").
> >
> > Cc: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> > Signed-off-by: José Roberto de Souza <jose.souza@xxxxxxxxx>
> > ---
> > Documentation/gpu/i915.rst | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/gpu/i915.rst b/Documentation/gpu/i915.rst
> > index bcaefc952764e..ab596b0a9f259 100644
> > --- a/Documentation/gpu/i915.rst
> > +++ b/Documentation/gpu/i915.rst
>
> Oh that's whete it's coming from.
>
> > @@ -187,10 +187,10 @@ Display Refresh Rate Switching (DRRS)
> > :doc: Display Refresh Rate Switching (DRRS)
> >
> > .. kernel-doc:: drivers/gpu/drm/i915/display/intel_drrs.c
> > - :functions: intel_drrs_enable
> > + :functions: intel_drrs_activate
>
> Hmm. Can't we just nuke all these explicit references and let the
> tooling pull in all of it automagically since there's nothing
> else in that file?
Indeed.
.. kernel-doc:: drivers/gpu/drm/i915/display/intel_drrs.c
:doc: Display Refresh Rate Switching (DRRS)
.. kernel-doc:: drivers/gpu/drm/i915/display/intel_drrs.c
:internal:
looks the right thing to do here.
And if the other matters, than sort the functions in intel_drrs.c
>
> >
> > .. kernel-doc:: drivers/gpu/drm/i915/display/intel_drrs.c
> > - :functions: intel_drrs_disable
> > + :functions: intel_drrs_deactivate
> >
> > .. kernel-doc:: drivers/gpu/drm/i915/display/intel_drrs.c
> > :functions: intel_drrs_invalidate
> > --
> > 2.35.1
>
> --
> Ville Syrjälä
> Intel
