On Tue, Mar 22, 2022 at 02:46:16PM -0700, José Roberto de Souza wrote: > skl_compute_ddb() will for a modeset in all pipes when MBUS joining > changes between states, so all pipes will be disabled, have all > MBUS related registers updated and then each pipe enabled. > So no vblank syncronization is necessary and here droping those TODOs. The TODO is about removing that modeset. So it should stay put. > > Cc: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > Signed-off-by: José Roberto de Souza <jose.souza@xxxxxxxxx> > --- > drivers/gpu/drm/i915/intel_pm.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c > index cf290bb704221..9ccf0f062862c 100644 > --- a/drivers/gpu/drm/i915/intel_pm.c > +++ b/drivers/gpu/drm/i915/intel_pm.c > @@ -6066,7 +6066,6 @@ skl_compute_ddb(struct intel_atomic_state *state) > return ret; > > if (old_dbuf_state->joined_mbus != new_dbuf_state->joined_mbus) { > - /* TODO: Implement vblank synchronized MBUS joining changes */ > ret = intel_modeset_all_pipes(state); > if (ret) > return ret; > @@ -8195,10 +8194,6 @@ static void update_mbus_pre_enable(struct intel_atomic_state *state) > if (!HAS_MBUS_JOINING(dev_priv)) > return; > > - /* > - * TODO: Implement vblank synchronized MBUS joining changes. > - * Must be properly coordinated with dbuf reprogramming. > - */ > if (dbuf_state->joined_mbus) { > mbus_ctl = MBUS_HASHING_MODE_1x4 | MBUS_JOIN | > MBUS_JOIN_PIPE_SELECT_NONE; > -- > 2.35.1 -- Ville Syrjälä Intel