> -----Original Message----- > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > Sent: Thursday, March 24, 2022 12:49 AM > To: Shankar, Uma <uma.shankar@xxxxxxxxx> > Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH] drm/i915/display: Extend DP HDR support to hsw+ > > On Wed, Mar 23, 2022 at 09:04:36PM +0200, Ville Syrjälä wrote: > > On Thu, Mar 24, 2022 at 12:15:22AM +0530, Uma Shankar wrote: > > > HSW+ platforms are able to send out HDR Metadata SDP DIP > > > packet as GMP. Hence, extending the support for HDR on DP encoders > > > for the same. > > > > > > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5389 > > > Cc: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > > Signed-off-by: Uma Shankar <uma.shankar@xxxxxxxxx> > > > --- > > > drivers/gpu/drm/i915/display/intel_dp.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c > > > b/drivers/gpu/drm/i915/display/intel_dp.c > > > index 9e19165fd175..e10d2c151abf 100644 > > > --- a/drivers/gpu/drm/i915/display/intel_dp.c > > > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > > > @@ -4939,7 +4939,7 @@ intel_dp_add_properties(struct intel_dp *intel_dp, > struct drm_connector *connect > > > intel_attach_dp_colorspace_property(connector); > > > } > > > > > > - if (IS_GEMINILAKE(dev_priv) || DISPLAY_VER(dev_priv) >= 11) > > > + if (IS_HASWELL(dev_priv) || DISPLAY_VER(dev_priv) >= 8) > > > > CHV does not have this at all, and HSW/BDW don't have it on transcoder EDP. > > Actually vlv/chv might have it since the vlv video DIP was supposedly ripped from ibx. > So potentially we could just enable this for all ilk+. > But that would require actual testing, so hsw+ seems like good enough for now. Sure, will update this. > > > > Also if we're going to attach this unconditionally then we should stop > > attaching it again in the LSPCON init path. Or we should skip this one > > when LSPCON is present. Ok, have taken care of it and sent out the next version. Thanks Ville for the feedback. Regards, Uma Shankar > > > > > drm_object_attach_property(&connector->base, > > > connector->dev- > >mode_config.hdr_output_metadata_property, > > > 0); > > > -- > > > 2.25.1 > > > > -- > > Ville Syrjälä > > Intel > > -- > Ville Syrjälä > Intel
