Re: [PATCH 00/22] drm: Review of mode copies

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 3/23/2022 3:39 AM, Dmitry Baryshkov wrote:
On 22/03/2022 01:37, Ville Syrjälä wrote:
On Tue, Mar 15, 2022 at 02:52:38PM -0400, Alex Deucher wrote:
On Mon, Mar 14, 2022 at 6:12 PM Ville Syrjälä
<ville.syrjala@xxxxxxxxxxxxxxx> wrote:

On Fri, Feb 18, 2022 at 12:03:41PM +0200, Ville Syrjala wrote:
   drm: Add drm_mode_init()
   drm/bridge: Use drm_mode_copy()
   drm/imx: Use drm_mode_duplicate()
   drm/panel: Use drm_mode_duplicate()
   drm/vc4: Use drm_mode_copy()
These have been pushed to drm-misc-next.

   drm/amdgpu: Remove pointless on stack mode copies
   drm/amdgpu: Use drm_mode_init() for on-stack modes
   drm/amdgpu: Use drm_mode_copy()
amdgpu ones are reviewed, but I'll leave them for the
AMD folks to push to whichever tree they prefer.

I pulled patches 2, 4, 5 into my tree.

Thanks.

For 3, I'm happy to have it
land via drm-misc with the rest of the mode_init changes if you'd
prefer.

Either way works for me. I don't yet have reviews yet for
the other drivers, so I'll proably hold off for a bit more
at least. And the i915 patch I'll be merging via drm-intel.

   drm/radeon: Use drm_mode_copy()
   drm/gma500: Use drm_mode_copy()
   drm/tilcdc: Use drm_mode_copy()
   drm/i915: Use drm_mode_copy()

Those are now all in.

Which leaves us with these stragglers:
   drm/hisilicon: Use drm_mode_init() for on-stack modes

   drm/msm: Nuke weird on stack mode copy
   drm/msm: Use drm_mode_init() for on-stack modes
   drm/msm: Use drm_mode_copy()

These three patches went beneath my radar for some reason.

I have just sent a replacement for the first patch ([1]). Other two patches can be pulled in msm/msm-next (or msm/msm-fixes) during the next development cycle if that works for you.

[1] https://patchwork.freedesktop.org/series/101682/

Agree with this approach.

We can replace the first patch with https://patchwork.freedesktop.org/series/101682/.

Thanks

Abhinav


   drm/mtk: Use drm_mode_init() for on-stack modes
   drm/rockchip: Use drm_mode_copy()
   drm/sti: Use drm_mode_copy()
   drm: Use drm_mode_init() for on-stack modes
   drm: Use drm_mode_copy()






[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux