On Thu, 17 Mar 2022, Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> wrote:
> On Thu, Mar 17, 2022 at 07:33:55PM +0200, Jani Nikula wrote:
>> The kernel preference is to use the __packed macro instead of the direct
>> __attribute__.
>>
>> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
Pushed, thanks.
BR,
Jani.
>
>> ---
>> drivers/gpu/drm/i915/display/intel_sdvo.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c b/drivers/gpu/drm/i915/display/intel_sdvo.c
>> index 158e750e5b4d..328a8f20c63b 100644
>> --- a/drivers/gpu/drm/i915/display/intel_sdvo.c
>> +++ b/drivers/gpu/drm/i915/display/intel_sdvo.c
>> @@ -283,7 +283,7 @@ static bool intel_sdvo_read_byte(struct intel_sdvo *intel_sdvo, u8 addr, u8 *ch)
>> static const struct {
>> u8 cmd;
>> const char *name;
>> -} __attribute__ ((packed)) sdvo_cmd_names[] = {
>> +} __packed sdvo_cmd_names[] = {
>> SDVO_CMD_NAME_ENTRY(RESET),
>> SDVO_CMD_NAME_ENTRY(GET_DEVICE_CAPS),
>> SDVO_CMD_NAME_ENTRY(GET_FIRMWARE_REV),
>> --
>> 2.30.2
--
Jani Nikula, Intel Open Source Graphics Center
