On Tue, Mar 15, 2022 at 06:48:12PM +0000, Souza, Jose wrote:
> On Tue, 2022-03-15 at 15:27 +0200, Ville Syrjala wrote:
> > @@ -217,13 +216,12 @@ void intel_drrs_enable(const struct intel_crtc_state *crtc_state)
> > void intel_drrs_disable(const struct intel_crtc_state *old_crtc_state)
> > {
> > struct intel_crtc *crtc = to_intel_crtc(old_crtc_state->uapi.crtc);
> > - struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
> >
> > if (!old_crtc_state->has_drrs)
> > return;
> >
> > - drm_dbg_kms(&dev_priv->drm, "[CRTC:%d:%s] Disabling DRRS\n",
> > - crtc->base.base.id, crtc->base.name);
> > + if (!old_crtc_state->hw.active)
> > + return;
>
>
> Changes looks good but now there will not be any DRRS debug message, can you at least add debug message in intel_drrs_compute_config() when DRRS is
> allowed?
I think we should just add it to the crtc state dump. It's sort of there
already by way of non-zero M2/N2, but I guess having a more explicit debug
for it wouldn't hurt.
>
> With that:
>
> Reviewed-by: José Roberto de Souza <jose.souza@xxxxxxxxx>
Thanks.
--
Ville Syrjälä
Intel
