Re: [PATCH v3 2/2] drm/i915/intel_combo_phy: Print procmon ref values

["Nautiyal, Ankit K" <ankit.k.nautiyal@xxxxxxxxx>]

On 3/15/2022 2:08 PM, Jani Nikula wrote:
> On Tue, 15 Mar 2022, Ankit Nautiyal <ankit.k.nautiyal@xxxxxxxxx> wrote:
> > Add debug print for Procmon Ref values, to help get the
> > voltage configurations of combo PHYs.
> >
> > v2: Used drm_dbg_kms for logs. (Jani)
> > Added names for different voltage levels. (Imre)
> >
> > Suggested-by: Imre Deak <imre.deak@xxxxxxxxx>
> > Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@xxxxxxxxx>
> > ---
> >   .../gpu/drm/i915/display/intel_combo_phy.c    | 36 +++++++++++++------
> >   1 file changed, 26 insertions(+), 10 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_combo_phy.c b/drivers/gpu/drm/i915/display/intel_combo_phy.c
> > index 4dfe77351b8b..7ccf45578a7f 100644
> > --- a/drivers/gpu/drm/i915/display/intel_combo_phy.c
> > +++ b/drivers/gpu/drm/i915/display/intel_combo_phy.c
> > @@ -25,18 +25,29 @@ enum {
> >   };
> >   
> >   static const struct icl_procmon {
> > +	char name[30];
> const char * please, and ditch those \0's in the initialization.

Thanks Jani. Fixed in new version.

Regards,

Ankit


> >   	u32 dw1, dw9, dw10;
> >   } icl_procmon_values[] = {
> > -	[PROCMON_0_85V_DOT_0] =
> > -		{ .dw1 = 0x00000000, .dw9 = 0x62AB67BB, .dw10 = 0x51914F96, },
> > -	[PROCMON_0_95V_DOT_0] =
> > -		{ .dw1 = 0x00000000, .dw9 = 0x86E172C7, .dw10 = 0x77CA5EAB, },
> > -	[PROCMON_0_95V_DOT_1] =
> > -		{ .dw1 = 0x00000000, .dw9 = 0x93F87FE1, .dw10 = 0x8AE871C5, },
> > -	[PROCMON_1_05V_DOT_0] =
> > -		{ .dw1 = 0x00000000, .dw9 = 0x98FA82DD, .dw10 = 0x89E46DC1, },
> > -	[PROCMON_1_05V_DOT_1] =
> > -		{ .dw1 = 0x00440000, .dw9 = 0x9A00AB25, .dw10 = 0x8AE38FF1, },
> > +	[PROCMON_0_85V_DOT_0] = {
> > +		.name = "0.85V dot0 (low-voltage)\0",
> > +		.dw1 = 0x00000000, .dw9 = 0x62AB67BB, .dw10 = 0x51914F96,
> > +	},
> > +	[PROCMON_0_95V_DOT_0] = {
> > +		.name = "0.95V dot0\0",
> > +		.dw1 = 0x00000000, .dw9 = 0x86E172C7, .dw10 = 0x77CA5EAB,
> > +	},
> > +	[PROCMON_0_95V_DOT_1] = {
> > +		.name = "0.95V dot1\0",
> > +		.dw1 = 0x00000000, .dw9 = 0x93F87FE1, .dw10 = 0x8AE871C5,
> > +	},
> > +	[PROCMON_1_05V_DOT_0] = {
> > +		.name = "1.05V dot0\0",
> > +		.dw1 = 0x00000000, .dw9 = 0x98FA82DD, .dw10 = 0x89E46DC1,
> > +	},
> > +	[PROCMON_1_05V_DOT_1] = {
> > +		.name = "1.05V dot1\0",
> > +		.dw1 = 0x00440000, .dw9 = 0x9A00AB25, .dw10 = 0x8AE38FF1,
> > +	},
> >   };
> >   
> >   static const struct icl_procmon *
> > @@ -113,6 +124,11 @@ static bool icl_verify_procmon_ref_values(struct drm_i915_private *dev_priv,
> >   
> >   	procmon = icl_get_procmon_ref_values(dev_priv, phy);
> >   
> > +	drm_dbg_kms(&dev_priv->drm,
> > +		    "Combo PHY %c %s PROCMON values : 0x%x, 0x%x, 0x%x\n",
> > +		    phy_name(phy), procmon->name, procmon->dw1, procmon->dw9,
> > +		    procmon->dw10);
> > +
> >   	ret = check_phy_reg(dev_priv, phy, ICL_PORT_COMP_DW1(phy),
> >   			    (0xff << 16) | 0xff, procmon->dw1);
> >   	ret &= check_phy_reg(dev_priv, phy, ICL_PORT_COMP_DW9(phy),