== Series Details == Series: Add GuC Error Capture Support URL : https://patchwork.freedesktop.org/series/101348/ State : warning == Summary == $ dim checkpatch origin/drm-tip d88514e8a355 drm/i915/guc: Update GuC ADS size for error capture lists -:39: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 -:323: WARNING:LONG_LINE: line length of 104 exceeds 100 columns #323: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c:653: + ads_blob_write(guc, ads.capture_class[i][j], ads_ggtt + capture_offset); -:344: WARNING:LONG_LINE: line length of 107 exceeds 100 columns #344: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c:674: + ads_blob_write(guc, ads.capture_instance[i][j], ads_ggtt + capture_offset); -:468: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'regslist' - possible side-effects? #468: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c:63: +#define MAKE_REGLIST(regslist, regsowner, regstype, class) \ + { \ + regslist, \ + ARRAY_SIZE(regslist), \ + TO_GCAP_DEF_OWNER(regsowner), \ + TO_GCAP_DEF_TYPE(regstype), \ + class, \ + } -:512: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 16) #512: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c:107: + if (reglists[i].owner == owner && reglists[i].type == type && [...] + return ®lists[i]; -:688: WARNING:OOM_MESSAGE: Possible unnecessary 'out of memory' message #688: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c:283: + if (!caplist) { + drm_dbg(&i915->drm, "GuC-capture: failed to alloc cached caplist"); -:730: WARNING:OOM_MESSAGE: Possible unnecessary 'out of memory' message #730: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c:325: + if (!null_header) { + drm_dbg(&i915->drm, "GuC-capture: failed to alloc cached nulllist"); total: 0 errors, 6 warnings, 1 checks, 749 lines checked 5e9033716ead drm/i915/guc: Add XE_LP static registers for GuC error capture. -:26: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #26: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c:25: +#define COMMON_GEN12BASE_GLOBAL() \ + {GEN12_FAULT_TLB_DATA0, 0, 0, "GEN12_FAULT_TLB_DATA0"}, \ + {GEN12_FAULT_TLB_DATA1, 0, 0, "GEN12_FAULT_TLB_DATA1"}, \ + {FORCEWAKE_MT, 0, 0, "FORCEWAKE"}, \ + {GEN12_AUX_ERR_DBG, 0, 0, "AUX_ERR_DBG"}, \ + {GEN12_GAM_DONE, 0, 0, "GAM_DONE"}, \ + {GEN12_RING_FAULT_REG, 0, 0, "FAULT_REG"} -:34: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #34: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c:33: +#define COMMON_GEN12BASE_ENGINE_INSTANCE() \ + {RING_PSMI_CTL(0), 0, 0, "RC PSMI"}, \ + {RING_ESR(0), 0, 0, "ESR"}, \ + {RING_DMA_FADD(0), 0, 0, "RING_DMA_FADD_LDW"}, \ + {RING_DMA_FADD_UDW(0), 0, 0, "RING_DMA_FADD_UDW"}, \ + {RING_IPEIR(0), 0, 0, "IPEIR"}, \ + {RING_IPEHR(0), 0, 0, "IPEHR"}, \ + {RING_INSTPS(0), 0, 0, "INSTPS"}, \ + {RING_BBADDR(0), 0, 0, "RING_BBADDR_LOW32"}, \ + {RING_BBADDR_UDW(0), 0, 0, "RING_BBADDR_UP32"}, \ + {RING_BBSTATE(0), 0, 0, "BB_STATE"}, \ + {CCID(0), 0, 0, "CCID"}, \ + {RING_ACTHD(0), 0, 0, "ACTHD_LDW"}, \ + {RING_ACTHD_UDW(0), 0, 0, "ACTHD_UDW"}, \ + {RING_INSTPM(0), 0, 0, "INSTPM"}, \ + {RING_INSTDONE(0), 0, 0, "INSTDONE"}, \ + {RING_NOPID(0), 0, 0, "RING_NOPID"}, \ + {RING_START(0), 0, 0, "START"}, \ + {RING_HEAD(0), 0, 0, "HEAD"}, \ + {RING_TAIL(0), 0, 0, "TAIL"}, \ + {RING_CTL(0), 0, 0, "CTL"}, \ + {RING_MI_MODE(0), 0, 0, "MODE"}, \ + {RING_CONTEXT_CONTROL(0), 0, 0, "RING_CONTEXT_CONTROL"}, \ + {RING_HWS_PGA(0), 0, 0, "HWS"}, \ + {RING_MODE_GEN7(0), 0, 0, "GFX_MODE"}, \ + {GEN8_RING_PDP_LDW(0, 0), 0, 0, "PDP0_LDW"}, \ + {GEN8_RING_PDP_UDW(0, 0), 0, 0, "PDP0_UDW"}, \ + {GEN8_RING_PDP_LDW(0, 1), 0, 0, "PDP1_LDW"}, \ + {GEN8_RING_PDP_UDW(0, 1), 0, 0, "PDP1_UDW"}, \ + {GEN8_RING_PDP_LDW(0, 2), 0, 0, "PDP2_LDW"}, \ + {GEN8_RING_PDP_UDW(0, 2), 0, 0, "PDP2_UDW"}, \ + {GEN8_RING_PDP_LDW(0, 3), 0, 0, "PDP3_LDW"}, \ + {GEN8_RING_PDP_UDW(0, 3), 0, 0, "PDP3_UDW"} -:71: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #71: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c:70: +#define COMMON_GEN12BASE_RENDER() \ + {GEN7_SC_INSTDONE, 0, 0, "GEN7_SC_INSTDONE"}, \ + {GEN12_SC_INSTDONE_EXTRA, 0, 0, "GEN12_SC_INSTDONE_EXTRA"}, \ + {GEN12_SC_INSTDONE_EXTRA2, 0, 0, "GEN12_SC_INSTDONE_EXTRA2"} -:76: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #76: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c:75: +#define COMMON_GEN12BASE_VEC() \ + {GEN12_SFC_DONE(0), 0, 0, "SFC_DONE[0]"}, \ + {GEN12_SFC_DONE(1), 0, 0, "SFC_DONE[1]"}, \ + {GEN12_SFC_DONE(2), 0, 0, "SFC_DONE[2]"}, \ + {GEN12_SFC_DONE(3), 0, 0, "SFC_DONE[3]"} total: 4 errors, 0 warnings, 0 checks, 180 lines checked fa824b3c1885 drm/i915/guc: Add XE_LP steered register lists support -:70: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 16) #70: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c:163: + if (reglists[i].owner == owner && reglists[i].type == type && [...] + return ®lists[i]; total: 0 errors, 1 warnings, 0 checks, 260 lines checked d517212e3bc6 drm/i915/guc: Add DG2 registers for GuC error state capture. cb36f6528184 drm/i915/guc: Add Gen9 registers for GuC error state capture. -:23: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #23: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c:28: +#define COMMON_GEN9BASE_GLOBAL() \ + {GEN8_FAULT_TLB_DATA0, 0, 0, "GEN8_FAULT_TLB_DATA0"}, \ + {GEN8_FAULT_TLB_DATA1, 0, 0, "GEN8_FAULT_TLB_DATA1"}, \ + {ERROR_GEN6, 0, 0, "ERROR_GEN6"}, \ + {DONE_REG, 0, 0, "DONE_REG"}, \ + {HSW_GTT_CACHE_EN, 0, 0, "HSW_GTT_CACHE_EN"} -:39: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #39: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c:42: +#define COMMON_BASE_ENGINE_INSTANCE() \ {RING_PSMI_CTL(0), 0, 0, "RC PSMI"}, \ {RING_ESR(0), 0, 0, "ESR"}, \ {RING_DMA_FADD(0), 0, 0, "RING_DMA_FADD_LDW"}, \ total: 2 errors, 0 warnings, 0 checks, 146 lines checked dbe0bc5ebd32 drm/i915/guc: Add GuC's error state capture output structures. bf5c9b7ad048 drm/i915/guc: Update GuC-log relay function names 057f767cdab2 drm/i915/guc: Add capture region into intel_guc_log -:58: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #58: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_log.c:217: + log_buf_state = src_data = log->buf_addr; total: 0 errors, 0 warnings, 1 checks, 155 lines checked 327c5e5e8b4f drm/i915/guc: Check sizing of guc_capture output f177743e1ffe drm/i915/guc: Extract GuC error capture lists on G2H notification. d8e90d0c2a55 drm/i915/guc: Pre-allocate output nodes for extraction b11696a16cff drm/i915/guc: Plumb GuC-capture into gpu_coredump 8ff05662e8d4 drm/i915/guc: Print the GuC error capture output register list. -:132: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'a' - possible side-effects? #132: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c:1440: +#define __out(a, ...) \ + do { \ + drm_warn((&(a)->drm), __VA_ARGS__); \ + i915_error_printf((a), __VA_ARGS__); \ + } while (0) -:142: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ebuf' - possible side-effects? #142: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c:1450: +#define GCAP_PRINT_INTEL_ENG_INFO(ebuf, eng) \ + do { \ + __out(ebuf, " i915-Eng-Name: %s command stream\n", \ + (eng)->name); \ + __out(ebuf, " i915-Eng-Inst-Class: 0x%02x\n", (eng)->class); \ + __out(ebuf, " i915-Eng-Inst-Id: 0x%02x\n", (eng)->instance); \ + __out(ebuf, " i915-Eng-LogicalMask: 0x%08x\n", \ + (eng)->logical_mask); \ + } while (0) -:142: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'eng' - possible side-effects? #142: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c:1450: +#define GCAP_PRINT_INTEL_ENG_INFO(ebuf, eng) \ + do { \ + __out(ebuf, " i915-Eng-Name: %s command stream\n", \ + (eng)->name); \ + __out(ebuf, " i915-Eng-Inst-Class: 0x%02x\n", (eng)->class); \ + __out(ebuf, " i915-Eng-Inst-Id: 0x%02x\n", (eng)->instance); \ + __out(ebuf, " i915-Eng-LogicalMask: 0x%08x\n", \ + (eng)->logical_mask); \ + } while (0) -:152: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ebuf' - possible side-effects? #152: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c:1460: +#define GCAP_PRINT_GUC_INST_INFO(ebuf, node) \ + do { \ + __out(ebuf, " GuC-Engine-Inst-Id: 0x%08x\n", \ + (node)->eng_inst); \ + __out(ebuf, " GuC-Context-Id: 0x%08x\n", (node)->guc_id); \ + __out(ebuf, " LRCA: 0x%08x\n", (node)->lrca); \ + } while (0) -:152: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'node' - possible side-effects? #152: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c:1460: +#define GCAP_PRINT_GUC_INST_INFO(ebuf, node) \ + do { \ + __out(ebuf, " GuC-Engine-Inst-Id: 0x%08x\n", \ + (node)->eng_inst); \ + __out(ebuf, " GuC-Context-Id: 0x%08x\n", (node)->guc_id); \ + __out(ebuf, " LRCA: 0x%08x\n", (node)->lrca); \ + } while (0) total: 0 errors, 0 warnings, 5 checks, 286 lines checked
