== Series Details == Series: dyndbg add exclusive class support URL : https://patchwork.freedesktop.org/series/101265/ State : warning == Summary == $ dim checkpatch origin/drm-tip 7362a1150693 dyndbg: fix static_branch manipulation 38c78ef4dda7 dyndbg: add class_id field and query support -:55: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit a8f6c71f283e ("dyndbg: add class_id field and query support")' #55: a8f6c71f283e dyndbg: add class_id field and query support -:56: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #56: -:141: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'id' - possible side-effects? -:157: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'id' - possible side-effects? #157: FILE: include/linux/dynamic_debug.h:142: +#define __dynamic_func_call_cls(id, cls, fmt, func, ...) do { \ + DEFINE_DYNAMIC_DEBUG_METADATA_CLS(id, cls, fmt); \ + if (DYNAMIC_DEBUG_BRANCH(id)) \ + func(&id, ##__VA_ARGS__); \ } while (0) -:167: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'id' - possible side-effects? #167: FILE: include/linux/dynamic_debug.h:148: +#define __dynamic_func_call_no_desc_cls(id, cls, fmt, func, ...) do { \ + DEFINE_DYNAMIC_DEBUG_METADATA_CLS(id, cls, fmt); \ + if (DYNAMIC_DEBUG_BRANCH(id)) \ + func(__VA_ARGS__); \ } while (0) total: 1 errors, 1 warnings, 2 checks, 216 lines checked af3ef83dfd0c dyndbg: add DEFINE_DYNAMIC_DEBUG_CLASSBITS macro -:167: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'fsname' - possible side-effects? #167: FILE: include/linux/dynamic_debug.h:291: +#define DEFINE_DYNAMIC_DEBUG_CLASSBITS(fsname, _var, _flgs, desc, ...) \ + MODULE_PARM_DESC(fsname, desc); \ + static struct dyndbg_classbits_param ddcats_##_var = { \ + .bits = &(_var), \ + .flags = _flgs, \ + .classes = { __VA_ARGS__, _DPRINTK_SITE_UNCLASSED } \ + }; \ + module_param_cb(fsname, ¶m_ops_dyndbg_classbits, \ + &ddcats_##_var, 0644) -:231: CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #231: FILE: lib/dynamic_debug.c:650: + dcp->classes[i] < _DPRINTK_SITE_UNCLASSED); i++) { + total: 0 errors, 0 warnings, 2 checks, 145 lines checked 718d3bf7a683 dyndbg: drop EXPORTed dynamic_debug_exec_queries e9b94040c396 dyndbg: show both old and new in change-info