On Thu, 10 Mar 2022, Ville Syrjala <ville.syrjala@xxxxxxxxxxxxxxx> wrote:
> From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
>
> Only seamless DRRS needs the frontbuffer tracking, so check for that.
> Also use != consistently instead of randomly picing < as the comparison
*picking
> operator.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx>
PS. Why do we have STATIC_DRRS_SUPPORT if we don't use it for anything?
We could just filter this during VBT parsing.
> ---
> drivers/gpu/drm/i915/display/intel_drrs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_drrs.c b/drivers/gpu/drm/i915/display/intel_drrs.c
> index fa715b8ea310..146f2cf7d01a 100644
> --- a/drivers/gpu/drm/i915/display/intel_drrs.c
> +++ b/drivers/gpu/drm/i915/display/intel_drrs.c
> @@ -152,7 +152,7 @@ static void intel_drrs_set_state(struct drm_i915_private *dev_priv,
> return;
> }
>
> - if (dev_priv->drrs.type < SEAMLESS_DRRS_SUPPORT) {
> + if (dev_priv->drrs.type != SEAMLESS_DRRS_SUPPORT) {
> drm_dbg_kms(&dev_priv->drm, "Only Seamless DRRS supported.\n");
> return;
> }
> @@ -326,7 +326,7 @@ static void intel_drrs_frontbuffer_update(struct drm_i915_private *dev_priv,
> struct drm_crtc *crtc;
> enum pipe pipe;
>
> - if (dev_priv->drrs.type == DRRS_NOT_SUPPORTED)
> + if (dev_priv->drrs.type != SEAMLESS_DRRS_SUPPORT)
> return;
>
> cancel_delayed_work(&dev_priv->drrs.work);
--
Jani Nikula, Intel Open Source Graphics Center
