✗ Fi.CI.CHECKPATCH: warning for Remove usage of list iterator past the loop body (rev5)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



== Series Details ==

Series: Remove usage of list iterator past the loop body (rev5)
URL   : https://patchwork.freedesktop.org/series/100822/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
ceb0dd20faa6 drivers: usb: remove usage of list iterator past the loop body
-:67: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#67: FILE: drivers/usb/gadget/udc/at91_udc.c:158:
+			seq_printf(s, "\treq %p len %d/%d buf %p\n",
+					&req->req, length,

total: 0 errors, 0 warnings, 1 checks, 463 lines checked
b749f91c0742 treewide: remove using list iterator after loop body as a ptr
-:38: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#38: 
#define gr_free_dma_desc(a, b) do { __gr_free_dma_desc(a, b); __magic_uninit(b); } while (0)

-:38: WARNING:COMMIT_COMMENT_SYMBOL: Commit log lines starting with '#' are dropped by git as comments
#38: 
#define gr_free_dma_desc(a, b) do { __gr_free_dma_desc(a, b); __magic_uninit(b); } while (0)

-:74: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 1 errors, 2 warnings, 0 checks, 9 lines checked
5f1777a3e9c2 treewide: fix incorrect use to determine if list is empty
bad42abafeb1 drivers: remove unnecessary use of list iterator variable
b7d60a03651d treewide: remove dereference of list iterator after loop body
d6c929398cf0 treewide: remove check of list iterator against head past the loop body
-:310: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#310: FILE: drivers/dma/ppc4xx/adma.c:947:
+				list_for_each_entry(tmp, &chan->chain,
 				    chain_node) {

-:322: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#322: FILE: drivers/dma/ppc4xx/adma.c:957:
+				BUG_ON(!iter);

-:507: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#507: FILE: drivers/gpu/drm/drm_memory.c:77:
+		if (tmp->bound <= offset
+		    && (tmp->bound + (tmp->pages << PAGE_SHIFT)) >=

-:1261: CHECK:CAMELCASE: Avoid CamelCase: <List>
#1261: FILE: drivers/staging/rtl8192e/rtl819x_TSProc.c:251:
+		list_for_each_entry(tmp, psearch_list, List) {

-:1262: CHECK:CAMELCASE: Avoid CamelCase: <Addr>
#1262: FILE: drivers/staging/rtl8192e/rtl819x_TSProc.c:252:
+			if (memcmp(tmp->Addr, Addr, 6) == 0 &&

-:1263: CHECK:CAMELCASE: Avoid CamelCase: <TSInfo>
#1263: FILE: drivers/staging/rtl8192e/rtl819x_TSProc.c:253:
+			    tmp->TSpec.f.TSInfo.field.ucTSID == TID &&

-:1263: CHECK:CAMELCASE: Avoid CamelCase: <ucTSID>
#1263: FILE: drivers/staging/rtl8192e/rtl819x_TSProc.c:253:
+			    tmp->TSpec.f.TSInfo.field.ucTSID == TID &&

-:1264: CHECK:CAMELCASE: Avoid CamelCase: <ucDirection>
#1264: FILE: drivers/staging/rtl8192e/rtl819x_TSProc.c:254:
+			    tmp->TSpec.f.TSInfo.field.ucDirection == dir) {

-:1265: CHECK:CAMELCASE: Avoid CamelCase: <pRet>
#1265: FILE: drivers/staging/rtl8192e/rtl819x_TSProc.c:255:
+				pRet = tmp;

-:1304: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1304: FILE: drivers/staging/rtl8192e/rtllib_rx.c:2629:
+		if (is_same_network(tmp, network,
+		   (tmp->ssid_len ? 1 : 0))) {

-:1384: WARNING:LONG_LINE_COMMENT: line length of 156 exceeds 100 columns
#1384: FILE: drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:248:
+	//		IEEE80211_DEBUG(IEEE80211_DL_TS, "ADD:%pM, TID:%d, dir:%d\n", tmp->Addr, tmp->TSpec.ts_info.ucTSID, tmp->TSpec.ts_info.ucDirection);

-:1450: CHECK:CAMELCASE: Avoid CamelCase: <Suid>
#1450: FILE: fs/cifs/smb2misc.c:158:
+			if (tmp->Suid == le64_to_cpu(thdr->SessionId)) {

-:1450: CHECK:CAMELCASE: Avoid CamelCase: <SessionId>
#1450: FILE: fs/cifs/smb2misc.c:158:
+			if (tmp->Suid == le64_to_cpu(thdr->SessionId)) {

total: 0 errors, 2 warnings, 11 checks, 1642 lines checked





[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux