On Wed, Feb 23, 2022 at 12:55:51PM -0800, José Roberto de Souza wrote: <snip> > + union { > + /* icl+ TC */ > + struct { > + u32 mg_refclkin_ctl; > + u32 mg_clktop2_coreclkctl1; > + u32 mg_clktop2_hsclkctl; > + u32 mg_pll_div0; > + u32 mg_pll_div1; > + u32 mg_pll_lf; > + u32 mg_pll_frac_lock; > + u32 mg_pll_ssc; > + u32 mg_pll_bias; > + u32 mg_pll_tdc_coldst_bias; > + u32 mg_pll_bias_mask; > + u32 mg_pll_tdc_coldst_bias_mask; > + }; > + > + /* bxt */ > + struct { > + /* bxt */ > + u32 ebb0; > + u32 ebb4; > + u32 pll0; > + u32 pll1; > + u32 pll2; > + u32 pll3; > + u32 pll6; > + u32 pll8; > + u32 pll9; > + u32 pll10; > + u32 pcsdw12; > + }; Wasn't there some funny compiler bug around anonymous unions? git log --grep='anon.*union' seems to agree. Please double check that stuff to make sure this is actually safe. -- Ville Syrjälä Intel