Re: [PATCH 2/4] drm/i915: Dump hw.enable and pipe_mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 17, 2022 at 12:32:19PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> 
> Include hw.enable and pipe_mode in the crtc debugfs state dump.
> These are fairly fundemental to the operation of the driver
> so not seeing them leaves us in the dark.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>

Okay looks good to have more debug info here

Reviewed-by: Manasi Navare <manasi.d.navare@xxxxxxxxx>

Manasi

> ---
>  drivers/gpu/drm/i915/display/intel_display_debugfs.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> index f1d78b1c7702..1740f24446bb 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> @@ -923,9 +923,12 @@ static void intel_crtc_info(struct seq_file *m, struct intel_crtc *crtc)
>  		   yesno(crtc_state->uapi.active),
>  		   DRM_MODE_ARG(&crtc_state->uapi.mode));
>  
> -	seq_printf(m, "\thw: active=%s, adjusted_mode=" DRM_MODE_FMT "\n",
> -		   yesno(crtc_state->hw.active),
> +	seq_printf(m, "\thw: enable=%s, active=%s\n",
> +		   yesno(crtc_state->hw.enable), yesno(crtc_state->hw.active));
> +	seq_printf(m, "\tadjusted_mode=" DRM_MODE_FMT "\n",
>  		   DRM_MODE_ARG(&crtc_state->hw.adjusted_mode));
> +	seq_printf(m, "\tpipe__mode=" DRM_MODE_FMT "\n",
> +		   DRM_MODE_ARG(&crtc_state->hw.pipe_mode));
>  
>  	seq_printf(m, "\tpipe src size=%dx%d, dither=%s, bpp=%d\n",
>  		   crtc_state->pipe_src_w, crtc_state->pipe_src_h,
> -- 
> 2.34.1
> 



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux