On Wed, Feb 16, 2022 at 09:41:40AM -0800, Lucas De Marchi wrote: > Use iosys_map_memset() to zero the private data as ADS may be either > on system or IO memory. > > Cc: Matt Roper <matthew.d.roper@xxxxxxxxx> > Cc: Thomas Hellström <thomas.hellstrom@xxxxxxxxxxxxxxx> > Cc: Daniel Vetter <daniel@xxxxxxxx> > Cc: John Harrison <John.C.Harrison@xxxxxxxxx> > Cc: Matthew Brost <matthew.brost@xxxxxxxxx> > Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@xxxxxxxxx> > Signed-off-by: Lucas De Marchi <lucas.demarchi@xxxxxxxxx> Reviewed-by: Matthew Brost <matthew.brost@xxxxxxxxx> > --- > drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c > index c61648ef3920..d924486490c1 100644 > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c > @@ -714,8 +714,8 @@ static void guc_ads_private_data_reset(struct intel_guc *guc) > if (!size) > return; > > - memset((void *)guc->ads_blob + guc_ads_private_data_offset(guc), 0, > - size); > + iosys_map_memset(&guc->ads_map, guc_ads_private_data_offset(guc), > + 0, size); > } > > /** > -- > 2.35.1 >