Hi Ville, On Fri, Feb 18, 2022 at 12:04:01PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > Replace the hand rolled drm_mode_duplicate() with the > real thing. > > @is_dup@ > @@ > drm_mode_duplicate(...) > { ... } > > @depends on !is_dup@ > expression dev, oldmode; > identifier newmode; > @@ > - newmode = drm_mode_create(dev); > + newmode = drm_mode_duplicate(dev, oldmode); > ... > - drm_mode_copy(newmode, oldmode); > > Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > Cc: Thierry Reding <thierry.reding@xxxxxxxxx> > Cc: Sam Ravnborg <sam@xxxxxxxxxxxx> Looks good, Acked-by: Sam Ravnborg <sam@xxxxxxxxxxxx>