== Series Details == Series: use dynamic-debug under drm.debug api URL : https://patchwork.freedesktop.org/series/100289/ State : warning == Summary == $ dim checkpatch origin/drm-tip ac4ad1168f5b dyndbg: fix static_branch manipulation 4a4ea4a784ff dyndbg: add class_id field and query support -:141: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'id' - possible side-effects? #141: FILE: include/linux/dynamic_debug.h:142: +#define __dynamic_func_call_cls(id, cls, fmt, func, ...) do { \ + DEFINE_DYNAMIC_DEBUG_METADATA_CLS(id, cls, fmt); \ + if (DYNAMIC_DEBUG_BRANCH(id)) \ + func(&id, ##__VA_ARGS__); \ } while (0) -:151: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'id' - possible side-effects? #151: FILE: include/linux/dynamic_debug.h:148: +#define __dynamic_func_call_no_desc_cls(id, cls, fmt, func, ...) do { \ + DEFINE_DYNAMIC_DEBUG_METADATA_CLS(id, cls, fmt); \ + if (DYNAMIC_DEBUG_BRANCH(id)) \ + func(__VA_ARGS__); \ } while (0) -:215: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #215: FILE: lib/dynamic_debug.c:140: + v3pr_info("%s: func=\"%s\" file=\"%s\" module=\"%s\" format=\"%.*s\" lineno=%u-%u class=%u\n", msg, total: 0 errors, 0 warnings, 3 checks, 211 lines checked ed68edd2481a dyndbg: add DEFINE_DYNAMIC_DEBUG_CLASSBITS macro and callbacks -:13: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #13: echo "module drm -p ; module drm class 0 +p ; module drm class 2 +p" >control -:37: WARNING:TYPO_SPELLING: 'doesnt' may be misspelled - perhaps 'doesn't'? #37: iface doesnt care about new flags added later ^^^^^^ -:164: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'fsname' - possible side-effects? #164: FILE: include/linux/dynamic_debug.h:291: +#define DEFINE_DYNAMIC_DEBUG_CLASSBITS(fsname, _var, _flgs, desc, ...) \ + MODULE_PARM_DESC(fsname, desc); \ + static struct dyndbg_classbits_param ddcats_##_var = { \ + .bits = &(_var), \ + .flags = _flgs, \ + .classes = { __VA_ARGS__, _DPRINTK_SITE_UNCLASSED } \ + }; \ + module_param_cb(fsname, ¶m_ops_dyndbg_classbits, \ + &ddcats_##_var, 0644) -:227: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #227: FILE: lib/dynamic_debug.c:649: + for (i = 0; i < _DPRINTK_SITE_UNCLASSED && + dcp->classes[i] < _DPRINTK_SITE_UNCLASSED; i++) { -:228: CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #228: FILE: lib/dynamic_debug.c:650: + dcp->classes[i] < _DPRINTK_SITE_UNCLASSED; i++) { + total: 0 errors, 2 warnings, 3 checks, 145 lines checked 1f8a67625036 dyndbg: drop EXPORTed dynamic_debug_exec_queries -:9: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #9: commit a2d375eda771 ("dyndbg: refine export, rename to dynamic_debug_exec_queries()") total: 0 errors, 1 warnings, 0 checks, 56 lines checked a52fd6c7132a dyndbg: improve change-info to have old and new c1ac85484894 dyndbg: abstract dyndbg_site_is_printing -:20: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'desc' may be better as '(desc)' to avoid precedence issues #20: FILE: include/linux/dynamic_debug.h:59: +#define dyndbg_site_is_printing(desc) (desc->flags & _DPRINTK_FLAGS_PRINT) total: 0 errors, 0 warnings, 1 checks, 8 lines checked f56d9ff10553 drm_print: condense enum drm_debug_category a8d888c7d80a drm_print: interpose drm_*dbg with forwarding macros -:80: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #80: FILE: include/drm/drm_print.h:338: +void __drm_dev_dbg(const struct device *dev, enum drm_debug_category category, const char *format, ...); total: 0 errors, 0 warnings, 1 checks, 59 lines checked eb86ea8ef18b drm_print: wrap drm_*_dbg in dyndbg jumplabel -:72: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'fmt' - possible side-effects? #72: FILE: include/drm/drm_print.h:390: +#define drm_dev_dbg(dev, cat, fmt, ...) \ + _dynamic_func_call_no_desc(fmt, __drm_dev_dbg, \ + dev, cat, fmt, ##__VA_ARGS__) -:86: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'fmt' - possible side-effects? #86: FILE: include/drm/drm_print.h:503: +#define __drm_dbg(cat, fmt, ...) \ + _dynamic_func_call_no_desc(fmt, ___drm_dbg, \ + cat, fmt, ##__VA_ARGS__) total: 0 errors, 0 warnings, 2 checks, 53 lines checked 1fc9e34c3b12 drm_print: refine drm_debug_enabled for dyndbg+jump-label 34e76601f0ab drm_print: prefer bare printk KERN_DEBUG on generic fn -:25: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #25: 462583 36604 54592 553779 87333 /lib/modules/5.16.0-rc4-lm1-00008-ged3eac8ceeea/kernel/drivers/gpu/drm/drm.ko -:51: WARNING:PREFER_PR_LEVEL: Prefer [subsystem eg: netdev]_dbg([subsystem]dev, ... then dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG ... #51: FILE: drivers/gpu/drm/drm_print.c:164: + printk(KERN_DEBUG "%s %pV", p->prefix, vaf); total: 0 errors, 2 warnings, 0 checks, 17 lines checked 39bbb4f0f2da drm_print: add _ddebug desc to drm_*dbg prototypes -:61: WARNING:PREFER_DEV_LEVEL: Prefer dev_dbg(... to dev_printk(KERN_DEBUG, ... #61: FILE: drivers/gpu/drm/drm_print.c:274: + dev_printk(KERN_DEBUG, dev, "[" DRM_NAME ":%ps] %pV", -:65: WARNING:PREFER_PR_LEVEL: Prefer [subsystem eg: netdev]_dbg([subsystem]dev, ... then dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG ... #65: FILE: drivers/gpu/drm/drm_print.c:278: + printk(KERN_DEBUG "[" DRM_NAME ":%ps] %pV", total: 0 errors, 2 warnings, 0 checks, 98 lines checked 5b2b6e5fdbad drm_print: use DEFINE_DYNAMIC_DEBUG_CLASSBITS for drm.debug -:62: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #62: FILE: drivers/gpu/drm/drm_print.c:58: +DEFINE_DYNAMIC_DEBUG_CLASSBITS(debug, __drm_debug, "p", + "enable drm.debug categories - 1 bit per category", total: 0 errors, 0 warnings, 1 checks, 48 lines checked
