On Thu, 2022-02-10 at 18:11 -0800, Umesh Nerlige Ramappa wrote:
> On Wed, Jan 26, 2022 at 02:48:20AM -0800, Alan Previn wrote:
> > Add a flags parameter through all of the coredump creation
> > functions. Add a bitmask flag to indicate if the top
> > level gpu_coredump event is triggered in response to
> > a GuC context reset notification.
> >
> > Using that flag, ensure all coredump functions that
> > read or print mmio-register values related to work submission
> > or command-streamer engines are skipped and replaced with
> > a calls guc-capture module equivalent functions to retrieve
> > or print the register dump.
> >
> > While here, split out display related register reading
> > and printing into its own function that is called agnostic
> > to whether GuC had triggered the reset.
> >
> > For now, introduce an empty printing function that can
> > filled in on a subsequent patch just to handle formatting.
> >
> > Signed-off-by: Alan Previn <alan.previn.teres.alexis@xxxxxxxxx>
> > +#if IS_ENABLED(CONFIG_DRM_I915_CAPTURE_ERROR)
> > +
> > +int intel_guc_capture_print_engine_node(struct drm_i915_error_state_buf *ebuf,
> > + const struct intel_engine_coredump *ee)
> > +{
> > + return 0;
>
> What goes here? Also return value is not used.
>
This was explained in the commit message, i wanted to keep all of the
plumbing touch points in this patch and handle just the straigt up
printing on a separate patch.
thanks again.
> >
